Clean-up inline members of nested classes (net/)

net/disk_cache/rankings.cc

Index: net/disk_cache/rankings.cc
diff --git a/net/disk_cache/rankings.cc b/net/disk_cache/rankings.cc
index 6da1e1f158530884d9065eea2b20b4ab4cb2763b..8559a9d07f45669e2c35711565e1094d2f0e6a5e 100644
--- a/net/disk_cache/rankings.cc
+++ b/net/disk_cache/rankings.cc
@@ -189,6 +189,14 @@ void UpdateTimes(disk_cache::CacheRankingsBlock* node, bool modified) {
 
 namespace disk_cache {
 
+Rankings::ScopedRankingsBlock::ScopedRankingsBlock() : rankings_(NULL) {}
+// XXX omitting the constructor name crashes clang. reduce & file.

[mmenke, 2012/08/09 15:13:35]

I can make no sense of this comment.

Also, should be in the form "TODO(hans): <blah>"

[hans, 2012/08/09 15:35:42]

I think this can just be removed.

+Rankings::ScopedRankingsBlock::ScopedRankingsBlock(Rankings* rankings)
+    : rankings_(rankings) {}
+Rankings::ScopedRankingsBlock::ScopedRankingsBlock(
+    Rankings* rankings, CacheRankingsBlock* node)
+    : scoped_ptr<CacheRankingsBlock>(node), rankings_(rankings) {}

[mmenke, 2012/08/09 15:13:35]

nit:  Line breaks between functions.

[hans, 2012/08/09 15:35:42]

Done.

+
 Rankings::Iterator::Iterator(Rankings* rankings) {
   memset(this, 0, sizeof(Iterator));
   my_rankings = rankings;