Clean-up inline members of nested classes (net/)

net/disk_cache/rankings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/disk_cache/rankings.h"
 
 #include "base/metrics/histogram.h"
 #include "net/disk_cache/backend_impl.h"
 #include "net/disk_cache/entry_impl.h"
 #include "net/disk_cache/errors.h"
@@ skipping 171 matching lines @@
   base::Time now = base::Time::Now();
   node->Data()->last_used = now.ToInternalValue();
   if (modified)
     node->Data()->last_modified = now.ToInternalValue();
 }
 
 }  // namespace
 
 namespace disk_cache {
 
+Rankings::ScopedRankingsBlock::ScopedRankingsBlock() : rankings_(NULL) {}
+// XXX omitting the constructor name crashes clang. reduce & file.

[mmenke, 2012/08/09 15:13:35]

I can make no sense of this comment.

Also, should be in the form "TODO(hans): <blah>"

[hans, 2012/08/09 15:35:42]

I think this can just be removed.

+Rankings::ScopedRankingsBlock::ScopedRankingsBlock(Rankings* rankings)
+    : rankings_(rankings) {}
+Rankings::ScopedRankingsBlock::ScopedRankingsBlock(
+    Rankings* rankings, CacheRankingsBlock* node)
+    : scoped_ptr<CacheRankingsBlock>(node), rankings_(rankings) {}

[mmenke, 2012/08/09 15:13:35]

nit:  Line breaks between functions.

[hans, 2012/08/09 15:35:42]

Done.

+
 Rankings::Iterator::Iterator(Rankings* rankings) {
   memset(this, 0, sizeof(Iterator));
   my_rankings = rankings;
 }
 
 Rankings::Iterator::~Iterator() {
   for (int i = 0; i < 3; i++)
     ScopedRankingsBlock(my_rankings, nodes[i]);
 }
 
@@ skipping 803 matching lines @@
 void Rankings::DecrementCounter(List list) {
   if (!count_lists_)
     return;
 
   DCHECK(control_data_->sizes[list] > 0);
   if (control_data_->sizes[list] > 0)
     control_data_->sizes[list]--;
 }
 
 }  // namespace disk_cache