Clean-up inline members of nested classes (net/)

net/tools/flip_server/balsa_headers.cc

Index: net/tools/flip_server/balsa_headers.cc
diff --git a/net/tools/flip_server/balsa_headers.cc b/net/tools/flip_server/balsa_headers.cc
index 0fe68c2abb27c4525d7c9d0e0949835b00698684..88a8a5e877824fcf1c9b989fea503b749c54cd22 100644
--- a/net/tools/flip_server/balsa_headers.cc
+++ b/net/tools/flip_server/balsa_headers.cc
@@ -70,10 +70,43 @@ namespace net {
 
 const size_t BalsaBuffer::kDefaultBlocksize;
 
+BalsaHeaders::iterator_base::iterator_base() : headers_(NULL), idx_(0) { }
+
+BalsaHeaders::iterator_base::iterator_base(const iterator_base& it)
+    : headers_(it.headers_),
+      idx_(it.idx_) {
+}
+
+BalsaHeaders::iterator_base::iterator_base(const BalsaHeaders* headers,
+                                           HeaderLines::size_type index)
+    : headers_(headers),
+      idx_(index) {
+}

[mmenke, 2012/08/09 15:13:35]

nit:  This one should be declared after operator<<, since that's where it
appears in the header.

[hans, 2012/08/09 15:35:42]

Done.

+
 std::ostream& BalsaHeaders::iterator_base::operator<<(std::ostream& os) const {
-   os << "[" << this->headers_ << ", " << this->idx_ << "]";
-   return os;
- }
+  os << "[" << this->headers_ << ", " << this->idx_ << "]";
+  return os;
+}
+
+BalsaHeaders::const_header_lines_key_iterator::const_header_lines_key_iterator(
+    const const_header_lines_key_iterator& other)
+    : iterator_base(other),
+      key_(other.key_) {
+}
+
+BalsaHeaders::const_header_lines_key_iterator::const_header_lines_key_iterator(
+    const BalsaHeaders* headers,
+    HeaderLines::size_type index,
+    const base::StringPiece& key)
+    : iterator_base(headers, index),
+      key_(key) {
+}
+
+BalsaHeaders::const_header_lines_key_iterator::const_header_lines_key_iterator(
+    const BalsaHeaders* headers,
+    HeaderLines::size_type index)
+    : iterator_base(headers, index) {
+}

[mmenke, 2012/08/09 15:13:35]

These should be down near the BalsaHeaders constructor, in the order they're
declared.

[hans, 2012/08/09 15:35:42]

Done.

 
 BalsaBuffer::~BalsaBuffer() {
   CleanupBlocksStartingFrom(0);