Clean-up inline members of nested classes (net/)

net/tools/flip_server/balsa_headers.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/tools/flip_server/balsa_headers.h"
 
 #include <stdio.h>
 #include <algorithm>
 #include <ext/hash_set>
 #include <string>
@@ skipping 52 matching lines @@
 REGISTER_MODULE_INITIALIZER(multivalued_headers, InitMultivaluedHeaders());
 
 const int kFastToBufferSize = 32;  // I think 22 is adequate, but anyway..
 
 }  // namespace
 
 namespace net {
 
 const size_t BalsaBuffer::kDefaultBlocksize;
 
+BalsaHeaders::iterator_base::iterator_base() : headers_(NULL), idx_(0) { }
+
+BalsaHeaders::iterator_base::iterator_base(const iterator_base& it)
+    : headers_(it.headers_),
+      idx_(it.idx_) {
+}
+
+BalsaHeaders::iterator_base::iterator_base(const BalsaHeaders* headers,
+                                           HeaderLines::size_type index)
+    : headers_(headers),
+      idx_(index) {
+}

[mmenke, 2012/08/09 15:13:35]

nit:  This one should be declared after operator<<, since that's where it
appears in the header.

[hans, 2012/08/09 15:35:42]

Done.

+
 std::ostream& BalsaHeaders::iterator_base::operator<<(std::ostream& os) const {
-   os << "[" << this->headers_ << ", " << this->idx_ << "]";
-   return os;
- }
+  os << "[" << this->headers_ << ", " << this->idx_ << "]";
+  return os;
+}
+
+BalsaHeaders::const_header_lines_key_iterator::const_header_lines_key_iterator(
+    const const_header_lines_key_iterator& other)
+    : iterator_base(other),
+      key_(other.key_) {
+}
+
+BalsaHeaders::const_header_lines_key_iterator::const_header_lines_key_iterator(
+    const BalsaHeaders* headers,
+    HeaderLines::size_type index,
+    const base::StringPiece& key)
+    : iterator_base(headers, index),
+      key_(key) {
+}
+
+BalsaHeaders::const_header_lines_key_iterator::const_header_lines_key_iterator(
+    const BalsaHeaders* headers,
+    HeaderLines::size_type index)
+    : iterator_base(headers, index) {
+}

[mmenke, 2012/08/09 15:13:35]

These should be down near the BalsaHeaders constructor, in the order they're
declared.

[hans, 2012/08/09 15:35:42]

Done.

 
 BalsaBuffer::~BalsaBuffer() {
   CleanupBlocksStartingFrom(0);
 }
 
 // Returns the total amount of memory used by the buffer blocks.
 size_t BalsaBuffer::GetTotalBufferBlockSize() const {
   size_t buffer_size = 0;
   for (Blocks::const_iterator iter = blocks_.begin();
        iter != blocks_.end();
@@ skipping 836 matching lines @@
 
 void BalsaHeaders::SetResponseReasonPhrase(const base::StringPiece& reason) {
   // Note: There is no difference between request_version() and
   // response_reason_phrase(). Thus, a function to set one is equivalent to a
   // function to set the other. We maintain two functions for this as it is
   // much more descriptive, and makes code more understandable.
   SetRequestVersion(reason);
 }
 
 }  // namespace net