Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 10854019: Make GetIntentServicesForExtensionFilter work synchronously (Closed)

Created:
8 years, 4 months ago by groby-ooo-7-16
Modified:
8 years, 4 months ago
Reviewers:
Greg Billock
CC:
chromium-reviews, gbillock+watch_chromium.org, smckay+watch_chromium.org
Visibility:
Public.

Description

Make GetIntentServicesForExtensionFilter work synchronously Since it does not require any IO tasks, it should not involved posting a task. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150662

Patch Set 1 #

Patch Set 2 : Make GetIntentServicesForExtensionFilter synchronous. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -71 lines) Patch
M chrome/browser/intents/web_intents_registry.h View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/intents/web_intents_registry.cc View 1 chunk +4 lines, -27 lines 0 comments Download
M chrome/browser/intents/web_intents_registry_unittest.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.h View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 2 chunks +33 lines, -25 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
groby-ooo-7-16
Limited success, but still one callback invocation and 30 lines of code less.
8 years, 4 months ago (2012-08-07 02:13:25 UTC) #1
groby-ooo-7-16
Odd. Missed Reviewers line the first time round - so, please review? :)
8 years, 4 months ago (2012-08-07 17:40:37 UTC) #2
Greg Billock
On 2012/08/07 17:40:37, groby wrote: > Odd. Missed Reviewers line the first time round - ...
8 years, 4 months ago (2012-08-08 22:54:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10854019/2001
8 years, 4 months ago (2012-08-08 23:30:44 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 01:06:30 UTC) #5
Change committed as 150662

Powered by Google App Engine
This is Rietveld 408576698