chrome/browser/intents/web_intents_registry_unittest.cc - Issue 10854019: Make GetIntentServicesForExtensionFilter work synchronously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/intents/web_intents_registry_unittest.cc

Issue 10854019: Make GetIntentServicesForExtensionFilter work synchronously (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make GetIntentServicesForExtensionFilter synchronous. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/intents/web_intents_registry_unittest.cc

diff --git a/chrome/browser/intents/web_intents_registry_unittest.cc b/chrome/browser/intents/web_intents_registry_unittest.cc

index 6ba804bdad667a30f1dc97a62433dedbe97f53b0..5f1ac6746da897671d99d611c7c4db53a0e77b23 100644

--- a/chrome/browser/intents/web_intents_registry_unittest.cc

+++ b/chrome/browser/intents/web_intents_registry_unittest.cc

@@ -258,18 +258,16 @@ TEST_F(WebIntentsRegistryTest, GetIntentServicesForExtensionFilter) {

extensions_.Insert(edit_extension);

ASSERT_EQ(2U, extensions_.size());

- ServiceListConsumer consumer;

+ WebIntentsRegistry::IntentServiceList services;

registry_.GetIntentServicesForExtensionFilter(

ASCIIToUTF16("http://webintents.org/edit"),

ASCIIToUTF16("image/*"),

edit_extension->id(),

- base::Bind(&ServiceListConsumer::Accept,

- base::Unretained(&consumer)));

- consumer.WaitForData();

- ASSERT_EQ(1U, consumer.services_.size());

+ &services);

+ ASSERT_EQ(1U, services.size());

EXPECT_EQ(edit_extension->url().spec() + "services/edit",

- consumer.services_[0].service_url.spec());

+ services[0].service_url.spec());

}

TEST_F(WebIntentsRegistryTest, GetAllIntents) {