Issue 10854003: Fix Mac ASAN build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10854003: Fix Mac ASAN build (Closed)

Created:
8 years, 4 months ago by pkotwicz

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix regressions in Mac ASAN build due to 150054 Switched to returning std::string instead of base::StringPiece in GetScaleFactorsAsString() as base::StringPiece does not take ownership of data passed to it in the constructor. TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150058

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	chrome/browser/themes/browser_theme_pack.cc	View		2 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10854003/1

8 years, 4 months ago (2012-08-06 00:51:49 UTC) #1

commit-bot: I haz the power

8 years, 4 months ago (2012-08-06 00:53:29 UTC) #2

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10854003/1

Expand Messages | Collapse Messages