Fix Mac ASAN build

chrome/browser/themes/browser_theme_pack.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/themes/browser_theme_pack.h"
 
 #include <limits>
 
 #include "base/memory/ref_counted_memory.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 185 matching lines @@
     if (index >= expected.size())
       return false;
     if (*end != ui::GetScaleFactorScale(expected[index]))
       return false;
     index++;
   }
   return (index == expected.size());
 }
 
 // Returns |scale_factors| as a string to be written to disk.
-base::StringPiece GetScaleFactorsAsString(
+std::string GetScaleFactorsAsString(
     const std::vector<ui::ScaleFactor>& scale_factors) {
   size_t scales_size = scale_factors.size() + 1;
   float* scales = new float[scales_size];
   for (size_t i = 0; i < scale_factors.size(); ++i)
     scales[i] = ui::GetScaleFactorScale(scale_factors[i]);
   scales[scales_size - 1] = -1.0f;
-  base::StringPiece out_string = base::StringPiece(
-      reinterpret_cast<const char*>(&scales),
+  std::string out_string = std::string(
+      reinterpret_cast<const char*>(scales),
       scales_size * sizeof(float));
   delete[] scales;
   return out_string;
 }
 
 struct StringToIntTable {
   const char* key;
   int id;
 };
 
@@ skipping 308 matching lines @@
       sizeof(DisplayPropertyPair[kDisplayPropertySize]));
 
   int source_count = 1;
   int* end = source_images_;
   for (; *end != -1 ; end++)
     source_count++;
   resources[kSourceImagesID] = base::StringPiece(
       reinterpret_cast<const char*>(source_images_),
       source_count * sizeof(*source_images_));
 
-  resources[kScaleFactorsID] = GetScaleFactorsAsString(scale_factors_);
+  // Store results of GetScaleFactorsAsString() in std::string as
+  // base::StringPiece does not copy data in constructor.
+  std::string scale_factors_string = GetScaleFactorsAsString(scale_factors_);
+  resources[kScaleFactorsID] = scale_factors_string;
 
   AddRawImagesTo(image_memory_, &resources);
 
   RawImages reencoded_images;
   RepackImages(images_on_file_thread_, &reencoded_images);
   AddRawImagesTo(reencoded_images, &resources);
 
   return ui::DataPack::WritePack(path, resources, ui::DataPack::BINARY);
 }
 
@@ skipping 675 matching lines @@
     ui::ScaleFactor scale_factor) const {
   if (prs_id < 0)
     return -1;
 
   for (size_t i = 0; i < scale_factors_.size(); ++i) {
     if (scale_factors_[i] == scale_factor)
       return static_cast<int>(kPersistingImagesLength * i) + prs_id;
   }
   return -1;
 }