Issue 10852003: Changes all non-workspace code to talk to WorkspaceManager via

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10852003: Changes all non-workspace code to talk to WorkspaceManager via (Closed)

Created:
8 years, 4 months ago by sky

Modified:
8 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Changes all non-workspace code to talk to WorkspaceManager via WorkspaceController. This is a precursor to making WorkspaceManager an interface and adding a new WorkspaceManager variant for the new window heurisics. BUG=137342 TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149890

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -59 lines)			Patch
M	ash/ash.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/root_window_controller.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	ash/shell.cc	View	1	4 chunks	+7 lines, -8 lines	0 comments	Download
M	ash/wm/shelf_layout_manager.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	ash/wm/shelf_layout_manager.cc	View		3 chunks	+8 lines, -9 lines	0 comments	Download
M	ash/wm/workspace/workspace_event_filter_unittest.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	ash/wm/workspace/workspace_manager.h	View	1	3 chunks	+2 lines, -15 lines	0 comments	Download
M	ash/wm/workspace/workspace_manager.cc	View	1	2 chunks	+7 lines, -6 lines	0 comments	Download
M	ash/wm/workspace/workspace_manager_unittest.cc	View		5 chunks	+7 lines, -6 lines	0 comments	Download
A	ash/wm/workspace/workspace_types.h	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
M	ash/wm/workspace_controller.h	View	1	3 chunks	+12 lines, -6 lines	0 comments	Download
M	ash/wm/workspace_controller.cc	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	ash/wm/workspace_controller_test_helper.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10852003/2001

8 years, 4 months ago (2012-08-03 17:16:09 UTC) #3

Change committed as 149890