[sync] Disable Win 8 sync credential caching for M22

[sync] Disable Win 8 sync credential caching for M22

Sync credential caching is a Win 8 feature that allows Metro and Desktop
to share sync credentials under some circumstances. The feature is
slated to ship with M23, and should be disabled for M22.

This patch hides the feature behind the "--enable-sync-credential-caching"
flag.
BUG=139712
TBR=thakis@chromium.org
TEST=Sign in on Win 8 and make sure that "Sync Credentials" is not written to the default profile directory


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149803

[Raghu Simha, 2012-08-01 19:05:53]

Gideon, please review. Thanks.

Adding Drew as an FYI.

[gideonwald, 2012-08-01 19:09:43]

On 2012/08/01 19:05:53, rsimha wrote:
> Gideon, please review. Thanks.
> 
> Adding Drew as an FYI.

Looks good! (I assume the Website Settings thing is an unrelated/incidental
cleanup?) Thanks for cc'ing me.

[Raghu Simha, 2012-08-01 19:49:30]

On 2012/08/01 19:09:43, gideonwald wrote:
> On 2012/08/01 19:05:53, rsimha wrote:
> > Gideon, please review. Thanks.
> > 
> > Adding Drew as an FYI.
> 
> Looks good! (I assume the Website Settings thing is an unrelated/incidental
> cleanup?) Thanks for cc'ing me.

Right, unrelated cleanup that should've been done in any case.

Also, the code review website insists on an explicit L G T M (without spaces) in
the message - could one of you do the honours please? :)

[gideonwald, 2012-08-01 20:23:30]

On 2012/08/01 19:49:30, rsimha wrote:
> On 2012/08/01 19:09:43, gideonwald wrote:
> > On 2012/08/01 19:05:53, rsimha wrote:
> > > Gideon, please review. Thanks.
> > > 
> > > Adding Drew as an FYI.
> > 
> > Looks good! (I assume the Website Settings thing is an unrelated/incidental
> > cleanup?) Thanks for cc'ing me.
> 
> Right, unrelated cleanup that should've been done in any case.
> 
> Also, the code review website insists on an explicit L G T M (without spaces)
in
> the message - could one of you do the honours please? :)

LGTM but I'm pretty sure the code review system doesn't care about my opinion.
:)

[commit-bot: I haz the power, 2012-08-01 23:35:24]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Andrew T Wilson (Slow), 2012-08-01 23:55:17]

LGTM

[commit-bot: I haz the power, 2012-08-01 23:57:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsimha@chromium.org/10850002/1

[commit-bot: I haz the power, 2012-08-01 23:57:22]

Presubmit check for 10850002-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 1.3s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Raghu Simha, 2012-08-02 00:10:24]

+Nico for chrome/common OWNER approval. Thanks.

[commit-bot: I haz the power, 2012-08-03 01:25:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsimha@chromium.org/10850002/1

[commit-bot: I haz the power, 2012-08-03 07:26:50]

Change committed as 149803