Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2705)

Unified Diff: chrome/browser/sync/credential_cache_service_factory_win.cc

Issue 10850002: [sync] Disable Win 8 sync credential caching for M22 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/credential_cache_service_factory_win.cc
diff --git a/chrome/browser/sync/credential_cache_service_factory_win.cc b/chrome/browser/sync/credential_cache_service_factory_win.cc
index 98e836021599c7bf4f742e5687847114b543d801..7cc2a6ae37f00af26d223270a12cc0fb77f393d6 100644
--- a/chrome/browser/sync/credential_cache_service_factory_win.cc
+++ b/chrome/browser/sync/credential_cache_service_factory_win.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/sync/credential_cache_service_factory_win.h"
+#include "base/command_line.h"
#include "base/memory/singleton.h"
#include "base/win/windows_version.h"
#include "chrome/browser/profiles/profile.h"
@@ -13,6 +14,7 @@
#include "chrome/browser/sync/credential_cache_service_win.h"
#include "chrome/browser/sync/profile_sync_service_factory.h"
#include "chrome/common/chrome_paths_internal.h"
+#include "chrome/common/chrome_switches.h"
namespace syncer {
@@ -57,9 +59,11 @@ bool CredentialCacheServiceFactory::ServiceIsCreatedWithProfile() {
ProfileKeyedService* CredentialCacheServiceFactory::BuildServiceInstanceFor(
Profile* profile) const {
// Only instantiate a CredentialCacheService object if we are running in the
- // default profile on Windows 8.
+ // default profile on Windows 8, and if credential caching is enabled.
+ const CommandLine* command_line = CommandLine::ForCurrentProcess();
if (base::win::GetVersion() >= base::win::VERSION_WIN8 &&
- IsDefaultProfile(profile)) {
+ IsDefaultProfile(profile) &&
+ command_line->HasSwitch(switches::kEnableSyncCredentialCaching)) {
return new syncer::CredentialCacheService(profile);
}
return NULL;
« no previous file with comments | « no previous file | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698