Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: lib/compiler/implementation/dart_backend/placeholder_collector.dart

Issue 10837343: Unify private names treatment. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/dart_backend/placeholder_collector.dart
diff --git a/lib/compiler/implementation/dart_backend/placeholder_collector.dart b/lib/compiler/implementation/dart_backend/placeholder_collector.dart
index e4813c71903645dea9d6e8e612ea50e4205624be..d6ad2180b2d6f606faeb9d855b41a4580b2da889 100644
--- a/lib/compiler/implementation/dart_backend/placeholder_collector.dart
+++ b/lib/compiler/implementation/dart_backend/placeholder_collector.dart
@@ -34,7 +34,7 @@ class SendVisitor extends ResolvedVisitor {
visitGetterSend(Send node) {
final element = elements[node];
// element === null means dynamic property access.
- if (element === null || element.isInstanceMember()) {
+ if (element === null || element.isMember()) {
Roman 2012/08/21 07:34:17 We didn't rename static fields before, why should
tryRenamePrivateSelector(node);
return;
}
@@ -299,11 +299,12 @@ class PlaceholderCollector extends AbstractVisitor {
}
visitSendSet(SendSet send) {
+ if (send.selector is Identifier) {
+ tryMakePrivateIdentifier(send.selector.asIdentifier());
+ }
final element = treeElements[send];
if (element !== null) {
- if (element.isInstanceMember()) {
- tryMakePrivateIdentifier(send.selector.asIdentifier());
- } else if (element.isTopLevel()) {
+ if (element.isTopLevel()) {
assert(element is VariableElement || element.isSetter());
makeElementPlaceholder(send.selector, element);
} else {

Powered by Google App Engine
This is Rietveld 408576698