Unify private names treatment.

lib/compiler/implementation/dart_backend/placeholder_collector.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class LocalPlaceholder implements Hashable {
   final String identifier;
   final Set<Node> nodes;
   LocalPlaceholder(this.identifier) : nodes = new Set<Node>();
   int hashCode() => identifier.hashCode();
   String toString() =>
@@ skipping 16 matching lines @@
     }
   }
 
   visitDynamicSend(Send node) {
     tryRenamePrivateSelector(node);
   }
 
   visitGetterSend(Send node) {
     final element = elements[node];
     // element === null means dynamic property access.
-    if (element === null || element.isInstanceMember()) {
+    if (element === null || element.isMember()) {

[Roman, 2012/08/21 07:34:17]

We didn't rename static fields before, why should we?

       tryRenamePrivateSelector(node);
       return;
     }
     // We don't want to rename non top-level element access
     // unless it's a local variable.
     if (element.isPrefix()) {
       // Node is prefix part in case of source 'lib.somesetter = 5;'
       collector.makeNullPlaceholder(node);
       return;
     } else if (!element.isTopLevel()) {
@@ skipping 244 matching lines @@
   visit(Node node) => (node === null) ? null : node.accept(this);
 
   visitNode(Node node) { node.visitChildren(this); }  // We must go deeper.
 
   visitSend(Send send) {
     new SendVisitor(this, treeElements).visitSend(send);
     send.visitChildren(this);
   }
 
   visitSendSet(SendSet send) {
+    if (send.selector is Identifier) {
+      tryMakePrivateIdentifier(send.selector.asIdentifier());
+    }
     final element = treeElements[send];
     if (element !== null) {
-      if (element.isInstanceMember()) {
-        tryMakePrivateIdentifier(send.selector.asIdentifier());
-      } else if (element.isTopLevel()) {
+      if (element.isTopLevel()) {
         assert(element is VariableElement || element.isSetter());
         makeElementPlaceholder(send.selector, element);
       } else {
         assert(send.selector is Identifier);
         tryMakeLocalPlaceholder(element, send.selector);
       }
     }
     send.visitChildren(this);
   }
 
@@ skipping 106 matching lines @@
       visit(node.defaultClause.typeArguments);
     }
   }
 
   visitTypedef(Typedef node) {
     assert(currentElement is TypedefElement);
     makeElementPlaceholder(node.name, currentElement);
     node.visitChildren(this);
   }
 }