Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1397)

Unified Diff: chrome/browser/extensions/script_badge_controller.cc

Issue 10837276: Change CHECK(false) into NOTREACHED in ScriptBadgeController, so that the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: log Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/script_badge_controller.cc
diff --git a/chrome/browser/extensions/script_badge_controller.cc b/chrome/browser/extensions/script_badge_controller.cc
index 87c0e891c9302df288f43e325459416a8b2b6d69..29de9a49d692789d19e794da38cb90399208d11c 100644
--- a/chrome/browser/extensions/script_badge_controller.cc
+++ b/chrome/browser/extensions/script_badge_controller.cc
@@ -128,7 +128,8 @@ void ScriptBadgeController::OnExecuteScriptFinished(
extension_id.c_str());
char buf[1024];
base::snprintf(buf, arraysize(buf), "%s", message.c_str());
- CHECK(false) << message;
+ LOG(ERROR) << message;
+ return;
}
}
@@ -204,7 +205,8 @@ void ScriptBadgeController::OnContentScriptsExecuting(
JoinExtensionIDs(extension_ids).c_str());
char buf[1024];
base::snprintf(buf, arraysize(buf), "%s", message.c_str());
- CHECK(false) << message;
+ LOG(ERROR) << message;
+ return;
}
bool changed = false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698