Change CHECK(false) into NOTREACHED in ScriptBadgeController, so that the

chrome/browser/extensions/script_badge_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/script_badge_controller.h"
 
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "chrome/browser/extensions/browser_event_router.h"
@@ skipping 110 matching lines @@
       NotifyChange();
   } else if (current_page_id < 0) {
     // Tracking down http://crbug.com/138323.
     std::string message = base::StringPrintf(
         "Expected a page ID of %d but there was no navigation entry. "
         "Extension ID is %s.",
         on_page_id,
         extension_id.c_str());
     char buf[1024];
     base::snprintf(buf, arraysize(buf), "%s", message.c_str());
-    CHECK(false) << message;
+    LOG(ERROR) << message;
+    return;
   }
 }
 
 ExtensionService* ScriptBadgeController::GetExtensionService() {
   return extensions::ExtensionSystem::Get(
       tab_contents_->profile())->extension_service();
 }
 
 int32 ScriptBadgeController::GetPageID() {
   content::NavigationEntry* nav_entry =
@@ skipping 55 matching lines @@
 
   if (current_page_id < 0) {
     // Tracking down http://crbug.com/138323.
     std::string message = base::StringPrintf(
         "Expected a page ID of %d but there was no navigation entry. "
         "Extension IDs are %s.",
         on_page_id,
         JoinExtensionIDs(extension_ids).c_str());
     char buf[1024];
     base::snprintf(buf, arraysize(buf), "%s", message.c_str());
-    CHECK(false) << message;
+    LOG(ERROR) << message;
+    return;
   }
 
   bool changed = false;
   for (std::set<std::string>::const_iterator it = extension_ids.begin();
        it != extension_ids.end(); ++it) {
     changed |= MarkExtensionExecuting(*it);
   }
   if (changed)
     NotifyChange();
 }
@@ skipping 45 matching lines @@
       current_actions_.erase(it);
       break;
     }
   }
 
   CHECK_EQ(size_before, current_actions_.size() + 1);
   return true;
 }
 
 }  // namespace extensions