Issue 10837276: Change CHECK(false) into NOTREACHED in ScriptBadgeController, so that the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Chromium Code Reviews

Issue 10837276: Change CHECK(false) into NOTREACHED in ScriptBadgeController, so that the (Closed)

Created:
8 years, 4 months ago by not at google - send to devlin

Modified:
8 years, 4 months ago

Reviewers:

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, benwells, koz (OOO until 15th September)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Change CHECK(false) into LOG(ERROR) in ScriptBadgeController, so that the official builds don't crash unnecessarily. BUG=138323 TBR=jyasskin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151804

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/extensions/script_badge_controller.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download