Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 10837258: Added UMA histograms' logging to Win8 SetAsDefault dialog (Closed)

Created:
8 years, 4 months ago by motek.
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Adds UMA histograms' logging to Win8 SetAsDefault dialog. R=mad BUG=141271 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152027

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed a typo (review). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M chrome/browser/ui/webui/set_as_default_browser_ui.cc View 1 8 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
motek.
8 years, 4 months ago (2012-08-15 14:18:14 UTC) #1
MAD
lgtm
8 years, 4 months ago (2012-08-15 17:27:52 UTC) #2
motek.
On 2012/08/15 17:27:52, MAD wrote: > lgtm @jhawkins Could I bother you for an owner's ...
8 years, 4 months ago (2012-08-15 18:11:35 UTC) #3
motek.
On 2012/08/15 17:27:52, MAD wrote: > lgtm Taking off jhawkins@, who is OOO and adding ...
8 years, 4 months ago (2012-08-16 19:43:24 UTC) #4
arv (Not doing code reviews)
https://chromiumcodereview.appspot.com/10837258/diff/1/chrome/browser/ui/webui/set_as_default_browser_ui.cc File chrome/browser/ui/webui/set_as_default_browser_ui.cc (right): https://chromiumcodereview.appspot.com/10837258/diff/1/chrome/browser/ui/webui/set_as_default_browser_ui.cc#newcode52 chrome/browser/ui/webui/set_as_default_browser_ui.cc:52: // REGRETED: user pressed Next but then elected a ...
8 years, 4 months ago (2012-08-16 19:46:20 UTC) #5
motek.
https://chromiumcodereview.appspot.com/10837258/diff/1/chrome/browser/ui/webui/set_as_default_browser_ui.cc File chrome/browser/ui/webui/set_as_default_browser_ui.cc (right): https://chromiumcodereview.appspot.com/10837258/diff/1/chrome/browser/ui/webui/set_as_default_browser_ui.cc#newcode52 chrome/browser/ui/webui/set_as_default_browser_ui.cc:52: // REGRETED: user pressed Next but then elected a ...
8 years, 4 months ago (2012-08-16 21:44:08 UTC) #6
arv (Not doing code reviews)
LGTM
8 years, 4 months ago (2012-08-16 22:07:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/motek@chromium.org/10837258/7001
8 years, 4 months ago (2012-08-16 22:20:02 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 02:49:21 UTC) #9
Change committed as 152027

Powered by Google App Engine
This is Rietveld 408576698