Added UMA histograms' logging to Win8 SetAsDefault dialog

chrome/browser/ui/webui/set_as_default_browser_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/set_as_default_browser_ui.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
+#include "base/metrics/histogram.h"
 #include "base/path_service.h"
 #include "chrome/browser/first_run/first_run.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/shell_integration.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
@@ skipping 17 matching lines @@
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/font.h"
 #include "ui/web_dialogs/web_dialog_delegate.h"
 
 using content::BrowserThread;
 using content::WebContents;
 using content::WebUIMessageHandler;
 
 namespace {
 
+const char kSetAsDefaultBrowserHistogram[] = "DefaultBrowser.InteractionResult";
+
+// The enum permits registering in UMA the three possible outcomes.
+// ACCEPTED: user pressed Next and made Chrome default.
+// DECLINED: user simply closed the dialog without making Chrome default.
+// REGRETED: user pressed Next but then elected a different default browser.

[arv (Not doing code reviews), 2012/08/16 19:46:20]

typo: regre_tt_ed

[motek., 2012/08/16 21:44:08]

Done.

+enum MakeChromeDefaultResult {
+  MAKE_CHROME_DEFAULT_ACCEPTED,
+  MAKE_CHROME_DEFAULT_DECLINED,
+  MAKE_CHROME_DEFAULT_REGRETED,
+  MAKE_CHROME_DEFAULT_MAX
+};
+
 ChromeWebUIDataSource* CreateSetAsDefaultBrowserUIHTMLSource() {
   ChromeWebUIDataSource* data_source = new ChromeWebUIDataSource(
       chrome::kChromeUIMetroFlowHost);
   data_source->AddLocalizedString("page-title", IDS_METRO_FLOW_TAB_TITLE);
   data_source->AddLocalizedString("flowTitle", IDS_METRO_FLOW_TITLE_SHORT);
   data_source->AddLocalizedString("flowDescription",
                                   IDS_METRO_FLOW_DESCRIPTION);
   data_source->AddLocalizedString("flowNext",
                                   IDS_METRO_FLOW_SET_DEFAULT);
   data_source->AddLocalizedString("chromeLogoString",
                                   IDS_METRO_FLOW_LOGO_STRING_ALT);
   data_source->set_json_path("strings.js");
   data_source->add_resource_path("set_as_default_browser.js",
       IDR_SET_AS_DEFAULT_BROWSER_JS);
   data_source->set_default_resource(IDR_SET_AS_DEFAULT_BROWSER_HTML);
   return data_source;
 }
 
 // A simple class serving as a delegate for passing down the result of the
 // interaction.
 class ResponseDelegate {
  public:
   virtual void SetChromeShutdownRequired(bool shutdown_chrome) = 0;
+  virtual void SetDialogInteractionResult(MakeChromeDefaultResult result) = 0;
 
  protected:
   virtual ~ResponseDelegate() { }
 };
 
 // Event handler for SetAsDefaultBrowserUI. Capable of setting Chrome as the
 // default browser on button click, closing itself and triggering Chrome
 // restart.
 class SetAsDefaultBrowserHandler
     : public WebUIMessageHandler,
@@ skipping 55 matching lines @@
     ShellIntegration::DefaultWebClientUIState state) {
   // The callback is expected to be invoked once the procedure has completed.
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (!set_default_returned_)
     return;
 
   if (state == ShellIntegration::STATE_NOT_DEFAULT && set_default_result_) {
     // The operation concluded, but Chrome is still not the default.
     // If the call has succeeded, this suggests user has decided not to make
     // chrome the default. We fold this UI and move on.
+    if (response_delegate_) {
+      response_delegate_->SetDialogInteractionResult(
+          MAKE_CHROME_DEFAULT_REGRETED);
+    }
+
     ConcludeInteraction(false);
   } else if (state == ShellIntegration::STATE_IS_DEFAULT) {
+    if (response_delegate_) {
+      response_delegate_->SetDialogInteractionResult(
+          MAKE_CHROME_DEFAULT_ACCEPTED);
+    }
+
     if (!Profile::FromWebUI(web_ui())->GetPrefs()->GetBoolean(
             prefs::kSuppressSwitchToMetroModeOnSetDefault)) {
       BrowserThread::PostTask(
           BrowserThread::FILE, FROM_HERE,
           base::Bind(&SetAsDefaultBrowserHandler::ActivateMetroChrome,
                      base::Unretained(this)));
     } else {
       ConcludeInteraction(false);
     }
   }
@@ skipping 71 matching lines @@
   virtual std::string GetDialogArgs() const OVERRIDE;
   virtual void OnDialogClosed(const std::string& json_retval) OVERRIDE;
   virtual void OnCloseContents(WebContents* source,
                                bool* out_close_dialog) OVERRIDE;
   virtual bool ShouldShowDialogTitle() const OVERRIDE;
   virtual bool HandleContextMenu(
       const content::ContextMenuParams& params) OVERRIDE;
 
   // Overridden from ResponseDelegate:
   virtual void SetChromeShutdownRequired(bool shutdown_chrome);
+  virtual void SetDialogInteractionResult(MakeChromeDefaultResult result);
 
  private:
   Profile* profile_;
   Browser* browser_;
   mutable bool owns_handler_;
   SetAsDefaultBrowserHandler* handler_;
+  MakeChromeDefaultResult dialog_interation_result_;
   bool response_is_close_chrome_;
 
   DISALLOW_COPY_AND_ASSIGN(SetAsDefaultBrowserDialogImpl);
 };
 
 SetAsDefaultBrowserDialogImpl::SetAsDefaultBrowserDialogImpl(Profile* profile,
                                                              Browser* browser)
     : profile_(profile),
       browser_(browser),
       owns_handler_(true),
       handler_(new SetAsDefaultBrowserHandler(this)),
+      dialog_interation_result_(MAKE_CHROME_DEFAULT_DECLINED),
       response_is_close_chrome_(false) {
 }
 
 SetAsDefaultBrowserDialogImpl::~SetAsDefaultBrowserDialogImpl() {
   if (owns_handler_)
     delete handler_;
 }
 
 void SetAsDefaultBrowserDialogImpl::ShowDialog() {
   chrome::ShowWebDialog(browser_->window()->GetNativeWindow(),
@@ skipping 29 matching lines @@
       IDS_METRO_FLOW_WIDTH_CHARS, IDS_METRO_FLOW_HEIGHT_LINES,
       approximate_web_font);
 }
 
 std::string SetAsDefaultBrowserDialogImpl::GetDialogArgs() const {
   return "[]";
 }
 
 void SetAsDefaultBrowserDialogImpl::OnDialogClosed(
     const std::string& json_retval) {
+  // Register the user's response in UMA.
+  UMA_HISTOGRAM_ENUMERATION(kSetAsDefaultBrowserHistogram,
+                            dialog_interation_result_,
+                            MAKE_CHROME_DEFAULT_MAX);
+
   if (response_is_close_chrome_) {
     // If Metro Chrome has been activated, we should close this process.
     // We are restarting as metro now.
     BrowserList::CloseAllBrowsersWithProfile(profile_);
   } else {
     // This will be false if the user closed the dialog without doing anything
     // or if operation failed for any reason (including invocation under a
     // Windows version earlier than 8).
     // In such case we just carry on with a normal chrome session. However, for
     // the purpose of surfacing this dialog the actual browser window had to
@@ skipping 20 matching lines @@
 bool SetAsDefaultBrowserDialogImpl::HandleContextMenu(
     const content::ContextMenuParams& params) {
   return true;
 }
 
 void SetAsDefaultBrowserDialogImpl::SetChromeShutdownRequired(
     bool shutdown_chrome) {
   response_is_close_chrome_ = shutdown_chrome;
 }
 
+void SetAsDefaultBrowserDialogImpl::SetDialogInteractionResult(
+    MakeChromeDefaultResult result) {
+  dialog_interation_result_ = result;
+}
+
 }  // namespace
 
 SetAsDefaultBrowserUI::SetAsDefaultBrowserUI(content::WebUI* web_ui)
     : ui::WebDialogUI(web_ui) {
   ChromeURLDataManager::AddDataSource(Profile::FromWebUI(web_ui),
                                       CreateSetAsDefaultBrowserUIHTMLSource());
 }
 
 // static
 void SetAsDefaultBrowserUI::Show(Profile* profile, Browser* browser) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   SetAsDefaultBrowserDialogImpl* dialog =
       new SetAsDefaultBrowserDialogImpl(profile, browser);
   dialog->ShowDialog();
 }