Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: tools/clang/plugins/ChromeClassTester.cpp

Issue 10837254: Style plugin: remove temporary flag for checking inner classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/ChromeClassTester.h ('k') | tools/clang/plugins/FindBadConstructs.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/ChromeClassTester.cpp
diff --git a/tools/clang/plugins/ChromeClassTester.cpp b/tools/clang/plugins/ChromeClassTester.cpp
index f32fbf108e7bc799495c069386ac18eb754f32a0..ae2210525ed283914c36014d12a11c39163da08c 100644
--- a/tools/clang/plugins/ChromeClassTester.cpp
+++ b/tools/clang/plugins/ChromeClassTester.cpp
@@ -37,11 +37,9 @@ bool ends_with(const std::string& one, const std::string& two) {
} // namespace
ChromeClassTester::ChromeClassTester(CompilerInstance& instance,
- bool check_inner_classes,
bool check_cc_directory)
: instance_(instance),
diagnostic_(instance.getDiagnostics()),
- check_inner_classes_(check_inner_classes),
check_cc_directory_(check_cc_directory) {
BuildBannedLists();
}
@@ -49,13 +47,7 @@ ChromeClassTester::ChromeClassTester(CompilerInstance& instance,
ChromeClassTester::~ChromeClassTester() {}
void ChromeClassTester::HandleTagDeclDefinition(TagDecl* tag) {
- if (check_inner_classes_) {
- // Defer processing of this tag until its containing top-level
- // declaration has been fully parsed. See crbug.com/136863.
- pending_class_decls_.push_back(tag);
- } else {
- CheckTag(tag);
- }
+ pending_class_decls_.push_back(tag);
}
bool ChromeClassTester::HandleTopLevelDecl(DeclGroupRef group_ref) {
« no previous file with comments | « tools/clang/plugins/ChromeClassTester.h ('k') | tools/clang/plugins/FindBadConstructs.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698