Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: tools/clang/plugins/FindBadConstructs.cpp

Issue 10837254: Style plugin: remove temporary flag for checking inner classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/ChromeClassTester.cpp ('k') | tools/clang/plugins/tests/test.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/FindBadConstructs.cpp
diff --git a/tools/clang/plugins/FindBadConstructs.cpp b/tools/clang/plugins/FindBadConstructs.cpp
index 0c41d7c54af2f955017075be4fde97251ae5cdc1..e6c444579f9ad303816190e8f50ddb0acf080d6b 100644
--- a/tools/clang/plugins/FindBadConstructs.cpp
+++ b/tools/clang/plugins/FindBadConstructs.cpp
@@ -51,9 +51,8 @@ class FindBadConstructsConsumer : public ChromeClassTester {
FindBadConstructsConsumer(CompilerInstance& instance,
bool check_refcounted_dtors,
bool check_virtuals_in_implementations,
- bool check_inner_classes,
bool check_cc_directory)
- : ChromeClassTester(instance, check_inner_classes, check_cc_directory),
+ : ChromeClassTester(instance, check_cc_directory),
check_refcounted_dtors_(check_refcounted_dtors),
check_virtuals_in_implementations_(check_virtuals_in_implementations) {
}
@@ -398,7 +397,6 @@ class FindBadConstructsAction : public PluginASTAction {
FindBadConstructsAction()
: check_refcounted_dtors_(true),
check_virtuals_in_implementations_(true),
- check_inner_classes_(false),
check_cc_directory_(false) {
}
@@ -408,7 +406,7 @@ class FindBadConstructsAction : public PluginASTAction {
llvm::StringRef ref) {
return new FindBadConstructsConsumer(
instance, check_refcounted_dtors_, check_virtuals_in_implementations_,
- check_inner_classes_, check_cc_directory_);
+ check_cc_directory_);
}
virtual bool ParseArgs(const CompilerInstance& instance,
@@ -421,7 +419,7 @@ class FindBadConstructsAction : public PluginASTAction {
} else if (args[i] == "skip-virtuals-in-implementations") {
check_virtuals_in_implementations_ = false;
} else if (args[i] == "check-inner-classes") {
- check_inner_classes_ = true;
+ // TODO(hans): Remove this once it's removed from plugin_flags.sh.
} else if (args[i] == "check-cc-directory") {
check_cc_directory_ = true;
} else {
@@ -436,7 +434,6 @@ class FindBadConstructsAction : public PluginASTAction {
private:
bool check_refcounted_dtors_;
bool check_virtuals_in_implementations_;
- bool check_inner_classes_;
bool check_cc_directory_;
};
« no previous file with comments | « tools/clang/plugins/ChromeClassTester.cpp ('k') | tools/clang/plugins/tests/test.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698