Issue 10837254: Style plugin: remove temporary flag for checking inner classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10837254: Style plugin: remove temporary flag for checking inner classes. (Closed)

Created:
8 years, 4 months ago by hans

Modified:
8 years, 4 months ago

Reviewers:
Nico

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Style plugin: remove temporary flag for checking inner classes. The flag was there to make checking of inner classes optional until all inner classes could be fixed. We must still parse the flag until this has been rolled in and plugin_flags.sh has been updated not to pass in the flag anymore. BUG=136863 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151727

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -21 lines)			Patch
M	tools/clang/plugins/ChromeClassTester.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	tools/clang/plugins/ChromeClassTester.cpp	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	tools/clang/plugins/FindBadConstructs.cpp	View	5 chunks	+3 lines, -6 lines	0 comments	Download
M	tools/clang/plugins/tests/test.sh	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/10837254/1

8 years, 4 months ago (2012-08-15 18:08:37 UTC) #3

Change committed as 151727

Expand Messages | Collapse Messages