Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2180)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Elements.java

Issue 10837237: Issue 4383. Calling field without setter should generate problem (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use same text for error as for warning Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/resolver/Resolver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/resolver/Elements.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/Elements.java b/compiler/java/com/google/dart/compiler/resolver/Elements.java
index 97ee1845e4c7caa2ad02c13ec24b433031dfb81b..1ec5ae72f57bd060d12c7a72d3171e1e8158f8a3 100644
--- a/compiler/java/com/google/dart/compiler/resolver/Elements.java
+++ b/compiler/java/com/google/dart/compiler/resolver/Elements.java
@@ -747,4 +747,22 @@ static FieldElementImplementation fieldFromNode(DartField node,
return false;
}
+ /**
+ * @return <code>true</code> if normal field or abstract field with getter.
+ */
+ public static boolean isFieldWithGetter(FieldElement fieldElement) {
+ if (fieldElement.getModifiers().isAbstractField()) {
+ return fieldElement.getGetter() != null;
+ }
+ return true;
+ }
+
+ public static boolean isAbstractFieldWithoutGetter(Element element) {
+ if (element instanceof FieldElement) {
+ FieldElement fieldElement = (FieldElement) element;
+ return fieldElement.getModifiers().isAbstractField() && fieldElement.getGetter() == null;
+ }
+ return false;
+ }
+
}
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/resolver/Resolver.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698