compiler/java/com/google/dart/compiler/resolver/Resolver.java - Issue 10837237: Issue 4383. Calling field without setter should generate problem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Resolver.java

Issue 10837237: Issue 4383. Calling field without setter should generate problem (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Use same text for error as for warning Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/Elements.java ('k') | compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/Resolver.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/Resolver.java b/compiler/java/com/google/dart/compiler/resolver/Resolver.java

index a5a5fa93c38501fa21d3b213873e7281c1a57780..d3b07f439cf46c6b63a4408599f7034a2a2fb8ef 100644

--- a/compiler/java/com/google/dart/compiler/resolver/Resolver.java

+++ b/compiler/java/com/google/dart/compiler/resolver/Resolver.java

@@ -1393,6 +1393,14 @@ public class Resolver {

} else {

checkInvocationTarget(x, currentMethod, element);

}

+ if (Elements.isAbstractFieldWithoutGetter(element)) {

+ String name = element.getName();

+ if (isStaticContextOrInitializer()) {

+ onError(x.getTarget(), ResolverErrorCode.USE_ASSIGNMENT_ON_SETTER, name);

+ } else {

+ onError(x.getTarget(), TypeErrorCode.USE_ASSIGNMENT_ON_SETTER, name);

+ }

recordElement(x, element);

recordElement(x.getTarget(), element);

visit(x.getArguments());