Move StoragePartition into content/public and remove BrowserContext::GetDOMStorageContext().

content/browser/web_contents/navigation_controller_impl.cc

Index: content/browser/web_contents/navigation_controller_impl.cc
diff --git a/content/browser/web_contents/navigation_controller_impl.cc b/content/browser/web_contents/navigation_controller_impl.cc
index 25d4874d1083a1bbfd6df35da7670c905ddb7d4a..befc43814144735c6954f52a20d92628ca351c1c 100644
--- a/content/browser/web_contents/navigation_controller_impl.cc
+++ b/content/browser/web_contents/navigation_controller_impl.cc
@@ -27,6 +27,7 @@
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
+#include "content/public/browser/storage_partition.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents_delegate.h"
 #include "content/public/common/content_client.h"
@@ -1299,11 +1300,15 @@ NavigationControllerImpl::GetSessionStorageNamespace(
     return it->second.get();
 
   // Create one if no one has accessed session storage for this partition yet.
+  //
+  // TODO(ajwong): Should this use the |partition_id| directly rather than
+  // re-lookup via |instance|?

[Charlie Reis, 2012/08/14 18:50:12]

Do you think there will be any other places that we'll have a partition_id on
hand?  If this is the only one, then it's not clear it's worth exposing
GetStoragePartitionByPartitionId in the public API.

[awong, 2012/08/14 19:12:47]

I think it's mostly a SessionStorage thing.  For right now, I'd rather leave it
as a double-lookup because it keeps SiteInstance as the only easy way to use the
API.  File a bug though.

+  content::StoragePartition* partition =
+              BrowserContext::GetStoragePartition(browser_context_, instance);

[Charlie Reis, 2012/08/14 18:50:12]

nit: Wrong indent.

[awong, 2012/08/14 19:12:47]

Done.

   SessionStorageNamespaceImpl* session_storage_namespace =
       new SessionStorageNamespaceImpl(
           static_cast<DOMStorageContextImpl*>(
-              BrowserContext::GetDOMStorageContextByPartitionId(
-                  browser_context_, partition_id)));
+              partition->GetDOMStorageContext()));
   session_storage_namespace_map_[partition_id] = session_storage_namespace;
 
   return session_storage_namespace;