Move StoragePartition into content/public and remove BrowserContext::GetDOMStorageContext().

content/browser/web_contents/navigation_controller_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/navigation_controller_impl.h"
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/string_number_conversions.h"  // Temporary
 #include "base/string_util.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "content/browser/browser_url_handler_impl.h"
 #include "content/browser/child_process_security_policy_impl.h"
 #include "content/browser/dom_storage/dom_storage_context_impl.h"
 #include "content/browser/dom_storage/session_storage_namespace_impl.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"  // Temporary
 #include "content/browser/site_instance_impl.h"
 #include "content/browser/web_contents/debug_urls.h"
 #include "content/browser/web_contents/interstitial_page_impl.h"
 #include "content/browser/web_contents/navigation_entry_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/common/view_messages.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/invalidate_type.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
+#include "content/public/browser/storage_partition.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents_delegate.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/common/url_constants.h"
 #include "net/base/escape.h"
 #include "net/base/mime_util.h"
 #include "net/base/net_util.h"
 #include "webkit/glue/webkit_glue.h"
 
@@ skipping 1252 matching lines @@
         GetContentClient()->browser()->GetStoragePartitionIdForSiteInstance(
             browser_context_, instance);
   }
 
   SessionStorageNamespaceMap::const_iterator it =
       session_storage_namespace_map_.find(partition_id);
   if (it != session_storage_namespace_map_.end())
     return it->second.get();
 
   // Create one if no one has accessed session storage for this partition yet.
+  //
+  // TODO(ajwong): Should this use the |partition_id| directly rather than
+  // re-lookup via |instance|?

[Charlie Reis, 2012/08/14 18:50:12]

Do you think there will be any other places that we'll have a partition_id on
hand?  If this is the only one, then it's not clear it's worth exposing
GetStoragePartitionByPartitionId in the public API.

[awong, 2012/08/14 19:12:47]

I think it's mostly a SessionStorage thing.  For right now, I'd rather leave it
as a double-lookup because it keeps SiteInstance as the only easy way to use the
API.  File a bug though.

+  content::StoragePartition* partition =
+              BrowserContext::GetStoragePartition(browser_context_, instance);

[Charlie Reis, 2012/08/14 18:50:12]

nit: Wrong indent.

[awong, 2012/08/14 19:12:47]

Done.

   SessionStorageNamespaceImpl* session_storage_namespace =
       new SessionStorageNamespaceImpl(
           static_cast<DOMStorageContextImpl*>(
-              BrowserContext::GetDOMStorageContextByPartitionId(
-                  browser_context_, partition_id)));
+              partition->GetDOMStorageContext()));
   session_storage_namespace_map_[partition_id] = session_storage_namespace;
 
   return session_storage_namespace;
 }
 
 SessionStorageNamespace*
 NavigationControllerImpl::GetDefaultSessionStorageNamespace() {
   // TODO(ajwong): Remove if statement in GetSessionStorageNamespace().
   return GetSessionStorageNamespace(NULL);
 }
@@ skipping 254 matching lines @@
   for (int i = 0; i < max_index; i++) {
     // When cloning a tab, copy all entries except interstitial pages
     if (source.entries_[i].get()->GetPageType() !=
         content::PAGE_TYPE_INTERSTITIAL) {
       entries_.insert(entries_.begin() + insert_index++,
                       linked_ptr<NavigationEntryImpl>(
                           new NavigationEntryImpl(*source.entries_[i])));
     }
   }
 }