Issue 10837229: Merge 150744 - As background-image doesn't have a notion of the size it is supposed to be, when the…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10837229: Merge 150744 - As background-image doesn't have a notion of the size it is supposed to be, when the… (Closed)

Created:
8 years, 4 months ago by kerz_chromium

Modified:
8 years, 4 months ago

Reviewers:
pkotwicz

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/branches/1229/src/

Visibility:
Public.

More Reviews

Description

Merge 150744 - As background-image doesn't have a notion of the size it is supposed to be, when the 2x version of the new tab background is requested and the request fails, the 1x version is shown but not pixel doubled. This CL specifies explicitly that only the 1x version is available. BUG=141171, 133934 Test=Manual, instructions below 1) Run chrome with --force-device-scale-factor=2 2) Change the theme to "Kate Spade" from the Chromium web store. 3) Ensure that the bookmark bar is hidden 4) Create a new tab. Ensure that the stripes in the new tab page match up with those in the tabstrip Review URL: https://chromiumcodereview.appspot.com/10836139 TBR=pkotwicz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151407

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -3 lines)			Patch
MM	chrome/browser/resources/new_incognito_tab_theme.css	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab_theme.css	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/ntp_search/new_tab_theme.css	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages