Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 10836139: Pixel double the NTP background (Closed)

Created:
8 years, 4 months ago by pkotwicz
Modified:
8 years, 4 months ago
Reviewers:
flackr, Nico, Dan Beam
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

As background-image doesn't have a notion of the size it is supposed to be, when the 2x version of the new tab background is requested and the request fails, the 1x version is shown but not pixel doubled. This CL specifies explicitly that only the 1x version is available. BUG=141171, 133934 Test=Manual, instructions below 1) Run chrome with --force-device-scale-factor=2 2) Change the theme to "Kate Spade" from the Chromium web store. 3) Ensure that the bookmark bar is hidden 4) Create a new tab. Ensure that the stripes in the new tab page match up with those in the tabstrip Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/resources/new_incognito_tab_theme.css View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/ntp4/new_tab_theme.css View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/ntp_search/new_tab_theme.css View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
pkotwicz
8 years, 4 months ago (2012-08-07 20:48:23 UTC) #1
flackr
lgtm, but I assume we'll need a way to conditionally support 2x theme backgrounds if/when ...
8 years, 4 months ago (2012-08-08 14:10:01 UTC) #2
pkotwicz
Nico can you take a look at this when you have time?
8 years, 4 months ago (2012-08-08 14:16:55 UTC) #3
Nico
With this patch, the 2x variant is never requested, right? Does that impact hidpi themes? ...
8 years, 4 months ago (2012-08-08 14:21:26 UTC) #4
pkotwicz
Yes, this patch has the effect that you have described. The 2x variant is never ...
8 years, 4 months ago (2012-08-08 17:33:30 UTC) #5
Dan Beam
rs lgtm (not really familiar with this nor do I have a high DPI screen ...
8 years, 4 months ago (2012-08-08 17:56:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10836139/1
8 years, 4 months ago (2012-08-08 18:37:35 UTC) #7
commit-bot: I haz the power
Try job failure for 10836139-1 (retry) on linux_rel for step "media_unittests". It's a second try, ...
8 years, 4 months ago (2012-08-08 19:55:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10836139/1
8 years, 4 months ago (2012-08-08 20:02:25 UTC) #9
commit-bot: I haz the power
Try job failure for 10836139-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-08 22:49:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10836139/1
8 years, 4 months ago (2012-08-09 01:06:39 UTC) #11
commit-bot: I haz the power
Try job failure for 10836139-1 (retry) on win for step "runhooks". It's a second try, ...
8 years, 4 months ago (2012-08-09 01:26:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10836139/1
8 years, 4 months ago (2012-08-09 02:36:07 UTC) #13
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 05:30:59 UTC) #14
Change committed as 150744

Powered by Google App Engine
This is Rietveld 408576698