Issue 10837219: Port the remaining of dart:coreimpl to the unified corelib.

Issue 10837219: Port the remaining of dart:coreimpl to the unified corelib. (Closed)

Created:
8 years, 4 months ago by Anders Johnsen

Modified:
8 years, 4 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Port the remaining of dart:coreimpl to the unified corelib. BUG= Committed: https://code.google.com/p/dart/source/detail?r=10569

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review fixes. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+164 lines, -424 lines)			Patch
A +	corelib/unified/core/expando.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
D	corelib/unified/core/implementation/date.dart	View		1 chunk	+0 lines, -181 lines	0 comments	Download
A +	corelib/unified/coreimpl/date.dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	corelib/unified/coreimpl/expando.dart	View		1 chunk	+6 lines, -5 lines	0 comments	Download
A +	corelib/unified/coreimpl/options.dart	View		1 chunk	+4 lines, -6 lines	0 comments	Download
A +	corelib/unified/coreimpl/stopwatch.dart	View		4 chunks	+22 lines, -6 lines	0 comments	Download
D	lib/compiler/implementation/lib/clock.dart	View		1 chunk	+0 lines, -20 lines	0 comments	Download
M	lib/compiler/implementation/lib/core.dart	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	lib/compiler/implementation/lib/coreimpl.dart	View		1 chunk	+4 lines, -3 lines	0 comments	Download
D	lib/compiler/implementation/lib/coreimpl.dartp	View		1 chunk	+0 lines, -53 lines	0 comments	Download
D	lib/compiler/implementation/lib/math.dartp	View		1 chunk	+0 lines, -105 lines	0 comments	Download
M	lib/compiler/implementation/lib/mock.dart	View		1 chunk	+0 lines, -39 lines	0 comments	Download
A	lib/compiler/implementation/lib/patch/coreimpl.dartp	View	1	1 chunk	+122 lines, -0 lines	0 comments	Download
A +	lib/compiler/implementation/lib/patch/math.dartp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/library_map.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/co19/co19-leg.status	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Patch files should be named .dartp. They are not containing valid dart code, so they ...

8 years, 4 months ago (2012-08-13 12:58:22 UTC) #1

Anders Johnsen

8 years, 4 months ago (2012-08-13 13:51:37 UTC) #2

https://chromiumcodereview.appspot.com/10837219/diff/1/lib/compiler/implement...
File lib/compiler/implementation/lib/patch/coreimpl.dart (right):

https://chromiumcodereview.appspot.com/10837219/diff/1/lib/compiler/implement...
lib/compiler/implementation/lib/patch/coreimpl.dart:5: // Patch file for
dart:core.
On 2012/08/13 12:58:22, Lasse Reichstein Nielsen wrote:
> dart:coreimpl

Done.

https://chromiumcodereview.appspot.com/10837219/diff/1/lib/compiler/implement...
File lib/compiler/implementation/lib/patch/math.dart (right):

https://chromiumcodereview.appspot.com/10837219/diff/1/lib/compiler/implement...
lib/compiler/implementation/lib/patch/math.dart:8: #import("js_helper.dart");
On 2012/08/13 12:58:22, Lasse Reichstein Nielsen wrote:
> ../ in front of path.

Done.

Expand Messages | Collapse Messages