Issue 10837215: exhibit 1: explicit null checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10837215: exhibit 1: explicit null checks

Created:
8 years, 4 months ago by Nico

Modified:
7 years, 7 months ago

Reviewers:

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jianli, Dmitry Titov, yoshiki+watch_chromium.org, dcheng, gideonwald, dominich, Aaron Boodman, rsesek+watch_chromium.org, jennb, David Black, Shishir, Jered

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

exhibit 1: explicit null checks not for review BUG=142930

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : rebase #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -54 lines)			Patch
M	chrome/browser/extensions/api/extension_action/extension_actions_api.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/favicon/favicon_tab_helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/instant/instant_controller.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_resource_providers.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 2 3	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm	View		1 chunk	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/content_settings/content_setting_bubble_model.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/location_bar_view_gtk.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/hung_renderer_view.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View	1 2 3	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/gfx/image/image.h	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	ui/gfx/image/image.cc	View		1 chunk	+0 lines, -14 lines	0 comments	Download