chrome/browser/favicon/favicon_tab_helper.cc - Issue 10837215: exhibit 1: explicit null checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_tab_helper.cc

Issue 10837215: exhibit 1: explicit null checks Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_tab_helper.cc

diff --git a/chrome/browser/favicon/favicon_tab_helper.cc b/chrome/browser/favicon/favicon_tab_helper.cc

index 649527224d2320742a7ed224d7447cb3d0478778..d7b5c8714a298090af34bdd92e95e199129e981e 100644

--- a/chrome/browser/favicon/favicon_tab_helper.cc

+++ b/chrome/browser/favicon/favicon_tab_helper.cc

@@ -116,7 +116,7 @@ void FaviconTabHelper::SaveFavicon() {

std::vector<unsigned char> image_data;

// TODO: Save all representations.

gfx::PNGCodec::EncodeBGRASkBitmap(

- favicon.image.AsBitmap(), false, &image_data);

+ *favicon.image.ToSkBitmap(), false, &image_data);

service->SetFavicon(

entry->GetURL(), favicon.url, image_data, history::FAVICON);

}