Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: content/browser/debugger/devtools_http_handler_impl.h

Issue 10837177: Add a menu item to content_shell to open devtools to make it more discoverable. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix android compile, and add gtk support Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/debugger/devtools_http_handler_impl.h
===================================================================
--- content/browser/debugger/devtools_http_handler_impl.h (revision 150609)
+++ content/browser/debugger/devtools_http_handler_impl.h (working copy)
@@ -53,6 +53,7 @@
virtual void Stop() OVERRIDE;
virtual void SetRenderViewHostBinding(
RenderViewHostBinding* binding) OVERRIDE;
+ virtual GURL GetFrontendURL(RenderViewHost* render_view_host) OVERRIDE;
// net::HttpServer::Delegate implementation.
virtual void OnHttpRequest(int connection_id,
@@ -64,16 +65,13 @@
const std::string& data) OVERRIDE;
virtual void OnClose(int connection_id) OVERRIDE;
- PageList GeneratePageList();
+ void OnJsonRequestUI(int connection_id,
+ const net::HttpServerRequestInfo& info);
+ void OnWebSocketRequestUI(int connection_id,
+ const net::HttpServerRequestInfo& info);
+ void OnWebSocketMessageUI(int connection_id, const std::string& data);
+ void OnCloseUI(int connection_id);
- virtual void OnJsonRequestUI(int connection_id,
- const net::HttpServerRequestInfo& info);
- virtual void OnWebSocketRequestUI(int connection_id,
- const net::HttpServerRequestInfo& info);
- virtual void OnWebSocketMessageUI(int connection_id,
- const std::string& data);
- virtual void OnCloseUI(int connection_id);
-
// net::URLRequest::Delegate implementation.
virtual void OnResponseStarted(net::URLRequest* request) OVERRIDE;
virtual void OnReadCompleted(net::URLRequest* request,
@@ -93,6 +91,12 @@
void AcceptWebSocket(int connection_id,
const net::HttpServerRequestInfo& request);
+ PageList GeneratePageList();
+
+ // Returns the front end url without the host at the beginning.
+ std::string GetFrontendURLInternal(const std::string rvh_id,
+ const std::string& host);
+
std::string overridden_frontend_url_;
scoped_ptr<const net::StreamListenSocketFactory> socket_factory_;
scoped_refptr<net::HttpServer> server_;

Powered by Google App Engine
This is Rietveld 408576698