Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: content/shell/shell_browser_main_parts.cc

Issue 10837177: Add a menu item to content_shell to open devtools to make it more discoverable. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix android compile, and add gtk support Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/shell_browser_context.h ('k') | content/shell/shell_content_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/shell_browser_main_parts.cc
===================================================================
--- content/shell/shell_browser_main_parts.cc (revision 150609)
+++ content/shell/shell_browser_main_parts.cc (working copy)
@@ -7,7 +7,6 @@
#include "base/bind.h"
#include "base/command_line.h"
#include "base/message_loop.h"
-#include "base/string_number_conversions.h"
#include "base/threading/thread.h"
#include "base/threading/thread_restrictions.h"
#include "content/public/common/content_switches.h"
@@ -82,22 +81,10 @@
#if defined(OS_ANDROID)
devtools_delegate_ = new ShellDevToolsDelegate(
- 0, // On android the port number isn't used.
browser_context_->GetRequestContext());
#else
- const CommandLine& command_line = *CommandLine::ForCurrentProcess();
- if (command_line.HasSwitch(switches::kRemoteDebuggingPort)) {
- std::string port_str =
- command_line.GetSwitchValueASCII(switches::kRemoteDebuggingPort);
- int port;
- if (base::StringToInt(port_str, &port) && port > 0 && port < 65535) {
- devtools_delegate_ = new ShellDevToolsDelegate(
- port,
- browser_context_->GetRequestContext());
- } else {
- DLOG(WARNING) << "Invalid http debugger port number " << port;
- }
- }
+ devtools_delegate_ = new ShellDevToolsDelegate(
+ browser_context_->GetRequestContext());
#endif
Avi (use Gerrit) 2012/08/09 19:18:00 How are these if branches different? I'll fix with
jam 2012/08/10 16:49:56 I missed that :)
if (!CommandLine::ForCurrentProcess()->HasSwitch(switches::kDumpRenderTree)) {
« no previous file with comments | « content/shell/shell_browser_context.h ('k') | content/shell/shell_content_browser_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698