Add a menu item to content_shell to open devtools to make it more discoverable.

Add a menu item to content_shell to open devtools to make it more discoverable.

Since the devtools server is running for each content shell browser process, the user doesn't specify a server port anymore. Instead I let the system pick. This made it necessary to plumb the data back from net::HttpServer.

For now I only added Windows and Linux UI. Mac UI will be done later.

BUG=90445
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150808

[jam, 2012-08-09 00:31:45]

ramant: net
pfeldman: everything else. also, should I get rid of
shell_devtools_discovery_page.html? or leave it in case people want to connect
from other browsers (which seems hard since they won't know the port)?

[ramant (doing other things), 2012-08-09 07:45:21]

net code LGTM.

[pfeldman, 2012-08-09 12:44:07]

devtools lgtm.

I think it is worth leaving the command line argument for the content shell in
case someone wants to attach to the instance as a part of the continuous
integration testing.

[jam, 2012-08-09 15:47:09]

On 2012/08/09 12:44:07, pfeldman wrote:
> devtools lgtm.
> 
> I think it is worth leaving the command line argument for the content shell in
> case someone wants to attach to the instance as a part of the continuous
> integration testing.

we have content_browsertests now, so if someone wanted an integration test for
content_shell it wouldn't need to be done from the outside with command line
flags. is that what you mean, or something else? either way, I'd prefer to take
it out if it's not used now, since it can be easily added back if someone needs
it.

[Avi (use Gerrit), 2012-08-09 19:18:00]

http://codereview.chromium.org/10837177/diff/10003/content/shell/shell_browse...
File content/shell/shell_browser_main_parts.cc (right):

http://codereview.chromium.org/10837177/diff/10003/content/shell/shell_browse...
content/shell/shell_browser_main_parts.cc:88: #endif
How are these if branches different? I'll fix with the Mac version.

[jam, 2012-08-10 16:49:56]

http://codereview.chromium.org/10837177/diff/10003/content/shell/shell_browse...
File content/shell/shell_browser_main_parts.cc (right):

http://codereview.chromium.org/10837177/diff/10003/content/shell/shell_browse...
content/shell/shell_browser_main_parts.cc:88: #endif
On 2012/08/09 19:18:00, Avi wrote:
> How are these if branches different? I'll fix with the Mac version.

I missed that :)