Chromium Code Reviews
Help | Chromium Project | Sign in
(172)

Issue 10837165: Lattice-based representation inference, powered by left/right specific type feedback for BinaryOps … (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by Jakob
Modified:
1 year, 5 months ago
Reviewers:
Kevin Millikin, danno
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Lattice-based representation inference, powered by left/right specific type feedback for BinaryOps and comparisons

Committed: https://code.google.com/p/v8/source/detail?r=12961

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : review candidate (ia32 only) #

Patch Set 5 : rebased onto r12511 #

Patch Set 6 : rebased onto r12629 #

Patch Set 7 : rebased onto r12751 #

Patch Set 8 : platform ports; cleanup; improvements #

Patch Set 9 : rebased onto r12851 #

Patch Set 10 : HConstants, HSimulates, stub fixes #

Total comments: 28

Patch Set 11 : review feedback #

Total comments: 2

Patch Set 12 : rebased onto r12944 #

Patch Set 13 : more performance polish #

Total comments: 4

Patch Set 14 : review feedback; fixed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2358 lines, -2372 lines) Lint Patch
M src/arm/code-stubs-arm.h View 1 2 3 4 5 6 7 8 9 3 chunks +6 lines, -117 lines 0 comments ? errors Download
M src/arm/code-stubs-arm.cc View 1 2 3 4 5 6 7 8 9 10 11 47 chunks +328 lines, -370 lines 0 comments ? errors Download
M src/arm/full-codegen-arm.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +3 lines, -24 lines 0 comments ? errors Download
M src/arm/ic-arm.cc View 1 2 3 4 5 6 7 8 9 1 chunk +8 lines, -29 lines 0 comments ? errors Download
M src/arm/lithium-arm.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments ? errors Download
M src/arm/lithium-arm.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M src/arm/lithium-codegen-arm.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +24 lines, -1 line 0 comments ? errors Download
M src/ast.h View 1 2 3 4 5 3 chunks +1 line, -8 lines 0 comments ? errors Download
M src/ast.cc View 1 2 3 4 5 6 7 2 chunks +1 line, -12 lines 0 comments ? errors Download
M src/code-stubs.h View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +144 lines, -102 lines 0 comments ? errors Download
M src/code-stubs.cc View 1 2 3 4 5 6 7 4 chunks +157 lines, -9 lines 0 comments 0 errors Download
M src/date.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments ? errors Download
M src/heap.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments ? errors Download
M src/hydrogen.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 6 chunks +27 lines, -7 lines 0 comments ? errors Download
M src/hydrogen.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 53 chunks +200 lines, -233 lines 0 comments ? errors Download
M src/hydrogen-instructions.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 32 chunks +168 lines, -64 lines 0 comments ? errors Download
M src/hydrogen-instructions.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 16 chunks +254 lines, -24 lines 0 comments ? errors Download
M src/ia32/code-stubs-ia32.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -90 lines 0 comments ? errors Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 56 chunks +337 lines, -402 lines 0 comments ? errors Download
M src/ia32/full-codegen-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -23 lines 0 comments ? errors Download
M src/ia32/ic-ia32.cc View 1 2 3 4 5 2 chunks +1 line, -35 lines 0 comments ? errors Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +30 lines, -1 line 0 comments ? errors Download
M src/ia32/lithium-ia32.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments ? errors Download
M src/ia32/lithium-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M src/ic.h View 1 2 3 4 5 6 7 4 chunks +15 lines, -20 lines 0 comments ? errors Download
M src/ic.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 10 chunks +187 lines, -119 lines 0 comments ? errors Download
M src/objects.h View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +5 lines, -41 lines 0 comments ? errors Download
M src/objects.cc View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +12 lines, -8 lines 0 comments ? errors Download
M src/objects-inl.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +36 lines, -61 lines 0 comments ? errors Download
M src/profile-generator.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +5 lines, -3 lines 0 comments ? errors Download
M src/type-info.h View 1 2 3 4 5 6 7 2 chunks +9 lines, -3 lines 0 comments ? errors Download
M src/type-info.cc View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +73 lines, -90 lines 0 comments ? errors Download
M src/x64/code-stubs-x64.h View 1 2 3 4 5 6 7 2 chunks +0 lines, -96 lines 0 comments ? errors Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 5 6 7 8 9 10 11 34 chunks +285 lines, -305 lines 0 comments ? errors Download
M src/x64/full-codegen-x64.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +3 lines, -29 lines 0 comments ? errors Download
M src/x64/ic-x64.cc View 1 2 3 4 5 6 7 2 chunks +1 line, -34 lines 0 comments ? errors Download
M src/x64/lithium-codegen-x64.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +24 lines, -1 line 0 comments ? errors Download
M src/x64/lithium-x64.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments ? errors Download
M src/x64/lithium-x64.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -2 lines 0 comments 0 errors Download
M test/cctest/test-api.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments ? errors Download
M test/mjsunit/math-floor-of-div-minus-zero.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 6
Jakob
The platform independent stuff and the ia32 port are ready for review. Please take a ...
1 year, 7 months ago #1
Jakob
Platform-independent parts are ready for review. Please take a look. To reduce the amount of ...
1 year, 6 months ago #2
danno
First round of comments http://codereview.chromium.org/10837165/diff/28001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/10837165/diff/28001/src/arm/code-stubs-arm.cc#newcode2485 src/arm/code-stubs-arm.cc:2485: void BinaryOpStub_GenerateHeapResultAllocation(MacroAssembler* masm, Make into ...
1 year, 5 months ago #3
Jakob
Feedback addressed. Also in this patch set: a few fixes that had crept in due ...
1 year, 5 months ago #4
danno
lgtm with nits http://codereview.chromium.org/10837165/diff/30002/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): http://codereview.chromium.org/10837165/diff/30002/src/hydrogen-instructions.h#newcode1335 src/hydrogen-instructions.h:1335: REMOVABLE, make this REMOVABLE_SIMULATE? http://codereview.chromium.org/10837165/diff/33002/src/hydrogen-instructions.cc File ...
1 year, 5 months ago #5
Jakob
1 year, 5 months ago #6
https://chromiumcodereview.appspot.com/10837165/diff/30002/src/hydrogen-instr...
File src/hydrogen-instructions.h (right):

https://chromiumcodereview.appspot.com/10837165/diff/30002/src/hydrogen-instr...
src/hydrogen-instructions.h:1335: REMOVABLE,
On 2012/11/14 10:38:22, danno wrote:
> make this REMOVABLE_SIMULATE?

Done.

https://chromiumcodereview.appspot.com/10837165/diff/33002/src/hydrogen-instr...
File src/hydrogen-instructions.cc (right):

https://chromiumcodereview.appspot.com/10837165/diff/33002/src/hydrogen-instr...
src/hydrogen-instructions.cc:2632: Representation HPhi::AllNonPhiUsesObserved()
{
On 2012/11/14 10:38:22, danno wrote:
> Add comment with what you described during the code review

Done.

https://chromiumcodereview.appspot.com/10837165/diff/33002/src/ic.cc
File src/ic.cc (right):

https://chromiumcodereview.appspot.com/10837165/diff/33002/src/ic.cc#newcode2429
src/ic.cc:2429: if (old_type == BinaryOpIC::UNINITIALIZED) return new_type;
On 2012/11/14 10:38:22, danno wrote:
> remove above?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6