Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 10837165: Lattice-based representation inference, powered by left/right specific type feedback for BinaryOps … (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: review feedback; fixed tests Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/ast.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 for (current_instruction_ = 0; 223 for (current_instruction_ = 0;
224 !is_aborted() && current_instruction_ < instructions_->length(); 224 !is_aborted() && current_instruction_ < instructions_->length();
225 current_instruction_++) { 225 current_instruction_++) {
226 LInstruction* instr = instructions_->at(current_instruction_); 226 LInstruction* instr = instructions_->at(current_instruction_);
227 if (instr->IsLabel()) { 227 if (instr->IsLabel()) {
228 LLabel* label = LLabel::cast(instr); 228 LLabel* label = LLabel::cast(instr);
229 emit_instructions = !label->HasReplacement(); 229 emit_instructions = !label->HasReplacement();
230 } 230 }
231 231
232 if (emit_instructions) { 232 if (emit_instructions) {
233 Comment(";;; @%d: %s.", current_instruction_, instr->Mnemonic()); 233 if (FLAG_code_comments) {
234 HValue* hydrogen = instr->hydrogen_value();
235 if (hydrogen != NULL) {
236 if (hydrogen->IsChange()) {
237 HValue* changed_value = HChange::cast(hydrogen)->value();
238 int use_id = 0;
239 const char* use_mnemo = "dead";
240 if (hydrogen->UseCount() >= 1) {
241 HValue* use_value = hydrogen->uses().value();
242 use_id = use_value->id();
243 use_mnemo = use_value->Mnemonic();
244 }
245 Comment(";;; @%d: %s. <of #%d %s for #%d %s>",
246 current_instruction_, instr->Mnemonic(),
247 changed_value->id(), changed_value->Mnemonic(),
248 use_id, use_mnemo);
249 } else {
250 Comment(";;; @%d: %s. <#%d>", current_instruction_,
251 instr->Mnemonic(), hydrogen->id());
252 }
253 } else {
254 Comment(";;; @%d: %s.", current_instruction_, instr->Mnemonic());
255 }
256 }
234 instr->CompileToNative(this); 257 instr->CompileToNative(this);
235 } 258 }
236 } 259 }
237 EnsureSpaceForLazyDeopt(); 260 EnsureSpaceForLazyDeopt();
238 return !is_aborted(); 261 return !is_aborted();
239 } 262 }
240 263
241 264
242 bool LCodeGen::GenerateDeferredCode() { 265 bool LCodeGen::GenerateDeferredCode() {
243 ASSERT(is_generating()); 266 ASSERT(is_generating());
(...skipping 5471 matching lines...) Expand 10 before | Expand all | Expand 10 after
5715 __ sub(scratch, result, Operand(index, LSL, kPointerSizeLog2 - kSmiTagSize)); 5738 __ sub(scratch, result, Operand(index, LSL, kPointerSizeLog2 - kSmiTagSize));
5716 __ ldr(result, FieldMemOperand(scratch, 5739 __ ldr(result, FieldMemOperand(scratch,
5717 FixedArray::kHeaderSize - kPointerSize)); 5740 FixedArray::kHeaderSize - kPointerSize));
5718 __ bind(&done); 5741 __ bind(&done);
5719 } 5742 }
5720 5743
5721 5744
5722 #undef __ 5745 #undef __
5723 5746
5724 } } // namespace v8::internal 5747 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/ast.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698