Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 10837103: Fix deallocation bug in TestingAutomationProvider (Closed)

Created:
8 years, 4 months ago by Russ Harmon
Modified:
8 years, 4 months ago
CC:
chromium-reviews, robertshield, kkania
Visibility:
Public.

Description

Fix deallocation bug in TestingAutomationProvider TBR=craigdh,nirnimesh Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150413

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
craigdh
My bad -- a DCHECK fails when reply goes out of scope. Thanks Russell.
8 years, 4 months ago (2012-08-03 21:04:30 UTC) #1
craigdh
lgtm, but you'll need OWNERs approval before committing.
8 years, 4 months ago (2012-08-03 21:06:09 UTC) #2
Nirnimesh
LGTM
8 years, 4 months ago (2012-08-03 21:06:19 UTC) #3
craigdh
+John for OWNERs approval
8 years, 4 months ago (2012-08-03 21:16:20 UTC) #4
Nirnimesh
-jam, since he's OOO +darin instead.
8 years, 4 months ago (2012-08-03 21:33:12 UTC) #5
darin (slow to review)
LGTM
8 years, 4 months ago (2012-08-03 22:20:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eatnumber@chromium.org/10837103/1
8 years, 4 months ago (2012-08-03 22:23:18 UTC) #7
commit-bot: I haz the power
Try job failure for 10837103-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-03 22:49:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eatnumber@chromium.org/10837103/1
8 years, 4 months ago (2012-08-07 19:25:49 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 21:21:21 UTC) #10
Change committed as 150413

Powered by Google App Engine
This is Rietveld 408576698