Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 10837103: Fix deallocation bug in TestingAutomationProvider (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/automation/testing_automation_provider.cc
diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc
index adb651d306947ec37467e07d185592bd1c8bb85b..c2c709c3e26f7c202f3e65db5ded43d3ab625bcf 100644
--- a/chrome/browser/automation/testing_automation_provider.cc
+++ b/chrome/browser/automation/testing_automation_provider.cc
@@ -1166,10 +1166,10 @@ void TestingAutomationProvider::OpenNewBrowserWindowOfType(
void TestingAutomationProvider::OpenNewBrowserWindow(
base::DictionaryValue* args,
IPC::Message* reply_message) {
- AutomationJSONReply reply(this, reply_message);
bool show;
if (!args->GetBoolean("show", &show)) {
- reply.SendError("'show' missing or invalid.");
+ AutomationJSONReply(this, reply_message)
+ .SendError("'show' missing or invalid.");
return;
}
new BrowserOpenedNotificationObserver(this, reply_message, true);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698