Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 10837065: Revert 149510 - Allow filters in accessibility tests to specify which attributes to check. (Closed)

Created:
8 years, 4 months ago by Peter Kasting
Modified:
8 years, 4 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Revert 149510 - Allow filters in accessibility tests to specify which attributes to check. This may have caused the Win 7 WebKit canary bot to begin crashing; see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=accessibility%2Floading-iframe-updates-axtree.html If rolling this out does not fix the bot, I will put it back in later tonight. With this change, a DumpAccessibilityTree test can specify filters to control which attributes are printed. This keeps each test expectation file small and readable, while making it easy to test for all sorts of attributes, including obscure ones. Each platform will have a few attributes that print by default, like the role and name. HTML files add rules of this form to override the defaults: @MAC-DENY:subrole* @MAC-DENY:value* @MAC-ALLOW:description* You can also specify @MAC-ALLOW:* or @WIN-ALLOW:* if you want to dump everything - helpful during development sometimes. BUG=124314 Review URL: https://chromiumcodereview.appspot.com/10662003 TBR=dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -443 lines) Patch
M content/browser/accessibility/browser_accessibility_win.h View 1 chunk +3 lines, -8 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 5 chunks +93 lines, -153 lines 0 comments Download
MM content/browser/accessibility/dump_accessibility_tree_helper.h View 4 chunks +0 lines, -36 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_helper.cc View 2 chunks +0 lines, -47 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_helper_mac.mm View 2 chunks +16 lines, -33 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_helper_win.cc View 2 chunks +18 lines, -49 lines 0 comments Download
M content/common/accessibility_node_data.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/accessibility_test_utils_win.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/test/accessibility_test_utils_win.cc View 1 chunk +24 lines, -22 lines 0 comments Download
M content/test/data/accessibility/a.html View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/data/accessibility/a-expected-win.txt View 1 chunk +4 lines, -4 lines 0 comments Download
MM content/test/data/accessibility/aria-application.html View 1 chunk +0 lines, -5 lines 0 comments Download
M content/test/data/accessibility/aria-application-expected-mac.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aria-application-expected-win.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/contenteditable-descendants.html View 1 chunk +0 lines, -5 lines 0 comments Download
M content/test/data/accessibility/contenteditable-descendants-expected-win.txt View 1 chunk +21 lines, -21 lines 0 comments Download
M content/test/data/accessibility/footer.html View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/data/accessibility/footer-expected-mac.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/footer-expected-win.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/list-markers-expected-mac.txt View 1 chunk +17 lines, -17 lines 0 comments Download
M content/test/data/accessibility/ul-expected-mac.txt View 1 chunk +11 lines, -11 lines 0 comments Download
M content/test/data/accessibility/ul-expected-win.txt View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Peter Kasting
8 years, 4 months ago (2012-08-02 01:04:36 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698