Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: content/browser/accessibility/dump_accessibility_tree_helper_mac.mm

Issue 10837065: Revert 149510 - Allow filters in accessibility tests to specify which attributes to check. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/dump_accessibility_tree_helper_mac.mm
===================================================================
--- content/browser/accessibility/dump_accessibility_tree_helper_mac.mm (revision 149548)
+++ content/browser/accessibility/dump_accessibility_tree_helper_mac.mm (working copy)
@@ -11,35 +11,26 @@
#include "content/browser/accessibility/browser_accessibility_cocoa.h"
#include "content/browser/accessibility/browser_accessibility_mac.h"
-namespace {
-string16 Format(BrowserAccessibility* node,
- const char *prefix,
- SEL selector,
- const char *suffix) {
- BrowserAccessibilityCocoa* cocoa_node = node->ToBrowserAccessibilityCocoa();
- NSString* format_str =
- [NSString stringWithFormat:@"%s%%@%s", prefix, suffix];
- NSString* tmp = [NSString stringWithFormat:format_str,
- [cocoa_node performSelector:selector]];
- return UTF8ToUTF16([tmp cStringUsingEncoding:NSUTF8StringEncoding]);
-}
-}
-
void DumpAccessibilityTreeHelper::Initialize() {}
string16 DumpAccessibilityTreeHelper::ToString(BrowserAccessibility* node,
char* prefix) {
- StartLine();
- Add(true, Format(node, "", @selector(role), ""));
- Add(true, Format(node, "subrole=", @selector(subrole), ""));
- Add(false, Format(node, "roleDescription='",
- @selector(roleDescription),
- "'"));
- Add(true, Format(node, "title='", @selector(title), "'"));
- Add(true, Format(node, "value='", @selector(value), "'"));
- Add(false, Format(node, "description='", @selector(description), "'"));
- Add(false, Format(node, "help='", @selector(help), "'"));
- return ASCIIToUTF16(prefix) + FinishLine() + ASCIIToUTF16("\n");
+ BrowserAccessibilityCocoa* cocoa_node = node->ToBrowserAccessibilityCocoa();
+ NSString* dump =
+ [NSString stringWithFormat:@"%s%@ "
+ "subrole=%@ "
+ "roleDescription='%@' "
+ "title='%@' "
+ "value='%@'\n",
+ prefix,
+ [cocoa_node role],
+ [cocoa_node subrole],
+ [cocoa_node roleDescription],
+ [cocoa_node title],
+ [cocoa_node value]];
+ std::string tempVal = [dump cStringUsingEncoding:NSUTF8StringEncoding];
+
+ return UTF8ToUTF16(tempVal);
}
const FilePath::StringType DumpAccessibilityTreeHelper::GetActualFileSuffix()
@@ -51,11 +42,3 @@
const {
return FILE_PATH_LITERAL("-expected-mac.txt");
}
-
-const std::string DumpAccessibilityTreeHelper::GetAllowString() const {
- return "@MAC-ALLOW:";
-}
-
-const std::string DumpAccessibilityTreeHelper::GetDenyString() const {
- return "@MAC-DENY:";
-}

Powered by Google App Engine
This is Rietveld 408576698