Don't show host permission warnings for platform apps.

Don't show host permission warnings for platform apps.

Since platform apps always use isolated storage, they can't (silently) access
user data on other domains, so there's no need to prompt.

BUG=130680
R=aa@chromium.org
TBR=phajdan.jr@chromium.org,atwilson@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149688

[Aaron Boodman, 2012-08-01 23:13:05]

Seems reasonable.

https://chromiumcodereview.appspot.com/10837060/diff/10/chrome/common/extensi...
File chrome/common/extensions/permissions/permission_set.cc (right):

https://chromiumcodereview.appspot.com/10837060/diff/10/chrome/common/extensi...
chrome/common/extensions/permissions/permission_set.cc:278: if
(!extension->is_platform_app()) {
Consider passing in only the type enum since that is all you are using.

[Aaron Boodman, 2012-08-01 23:13:13]

LGTM

[Mihai Parparita -not on Chrome, 2012-08-02 00:33:44]

I'll TBR the other OWNERS.

https://chromiumcodereview.appspot.com/10837060/diff/10/chrome/common/extensi...
File chrome/common/extensions/permissions/permission_set.cc (right):

https://chromiumcodereview.appspot.com/10837060/diff/10/chrome/common/extensi...
chrome/common/extensions/permissions/permission_set.cc:278: if
(!extension->is_platform_app()) {
On 2012/08/01 23:13:05, Aaron Boodman wrote:
> Consider passing in only the type enum since that is all you are using.

Done. Since this means #include-ing extension.h into permission_set.h, I had to
remove the permission_set.h #include in extension.h, which meant adding it a
bunch of places, that were relying on it appearing transitively. There's a TODO
about moving Extension::Type into its own header file, I'll look into doing
that.

[commit-bot: I haz the power, 2012-08-02 00:34:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mihaip@chromium.org/10837060/5002

[commit-bot: I haz the power, 2012-08-02 01:09:41]

Try job failure for 10837060-5002 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-08-02 18:14:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mihaip@chromium.org/10837060/10002

[commit-bot: I haz the power, 2012-08-02 18:15:16]

Failed to apply patch for chrome/common/extensions/extension_unittest.cc:
While running patch -p1 --forward --force;
patching file chrome/common/extensions/extension_unittest.cc
Hunk #1 FAILED at 19.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/common/extensions/extension_unittest.cc.rej

[commit-bot: I haz the power, 2012-08-02 18:28:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mihaip@chromium.org/10837060/1033

[commit-bot: I haz the power, 2012-08-02 20:17:12]

Change committed as 149688