Don't show host permission warnings for platform apps.

chrome/common/extensions/permissions/permission_set.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/permissions/permission_set.h"
 
 #include <algorithm>
 #include <iterator>
 #include <string>
 
@@ skipping 246 matching lines @@
   }
 
   return false;
 }
 
 std::set<std::string>
     PermissionSet::GetDistinctHostsForDisplay() const {
   return GetDistinctHosts(effective_hosts_, true, true);
 }
 
-PermissionMessages
-    PermissionSet::GetPermissionMessages() const {
+PermissionMessages PermissionSet::GetPermissionMessages(
+    const Extension* extension) const {
   PermissionMessages messages;
 
   if (HasEffectiveFullAccess()) {
     messages.push_back(PermissionMessage(
         PermissionMessage::kFullAccess,
         l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_FULL_ACCESS)));
     return messages;
   }
 
-  if (HasEffectiveAccessToAllHosts()) {
-    messages.push_back(PermissionMessage(
-        PermissionMessage::kHostsAll,
-        l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_ALL_HOSTS)));
-  } else {
-    std::set<std::string> hosts = GetDistinctHostsForDisplay();
-    if (!hosts.empty())
-      messages.push_back(PermissionMessage::CreateFromHostList(hosts));
+  if (!extension->is_platform_app()) {

[Aaron Boodman, 2012/08/01 23:13:05]

Consider passing in only the type enum since that is all you are using.

[Mihai Parparita -not on Chrome, 2012/08/02 00:33:44]

Done. Since this means #include-ing extension.h into permission_set.h, I had to
remove the permission_set.h #include in extension.h, which meant adding it a
bunch of places, that were relying on it appearing transitively. There's a TODO
about moving Extension::Type into its own header file, I'll look into doing
that.

+    if (HasEffectiveAccessToAllHosts()) {
+      messages.push_back(PermissionMessage(
+          PermissionMessage::kHostsAll,
+          l10n_util::GetStringUTF16(IDS_EXTENSION_PROMPT_WARNING_ALL_HOSTS)));
+    } else {
+      std::set<std::string> hosts = GetDistinctHostsForDisplay();
+      if (!hosts.empty())
+        messages.push_back(PermissionMessage::CreateFromHostList(hosts));
+    }
   }
 
   std::set<PermissionMessage> simple_msgs =
       GetSimplePermissionMessages();
   messages.insert(messages.end(), simple_msgs.begin(), simple_msgs.end());
 
   return messages;
 }
 
-std::vector<string16> PermissionSet::GetWarningMessages() const {
+std::vector<string16> PermissionSet::GetWarningMessages(
+    const Extension* extension) const {
   std::vector<string16> messages;
-  PermissionMessages permissions = GetPermissionMessages();
+  PermissionMessages permissions = GetPermissionMessages(extension);
 
   bool audio_capture = false;
   bool video_capture = false;
   for (PermissionMessages::const_iterator i = permissions.begin();
        i != permissions.end(); ++i) {
     if (i->id() == PermissionMessage::kAudioCapture)
       audio_capture = true;
     if (i->id() == PermissionMessage::kVideoCapture)
       video_capture = true;
   }
@@ skipping 278 matching lines @@
   std::set<std::string> new_hosts_only;
 
   std::set_difference(new_hosts_set.begin(), new_hosts_set.end(),
                       old_hosts_set.begin(), old_hosts_set.end(),
                       std::inserter(new_hosts_only, new_hosts_only.begin()));
 
   return !new_hosts_only.empty();
 }
 
 }  // namespace extensions