Issue 10837040: Added support in Helpapp for Manifest Version 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10837040: Added support in Helpapp for Manifest Version 2. (Closed)

Created:
8 years, 4 months ago by grovera

Modified:
8 years, 4 months ago

Reviewers:
Nikita (slow), abarth-chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/browser/resources/help_app/

Visibility:
Public.

More Reviews

Description

Added support in Helpapp for Manifest Version 2. BUG=chromium-os:33146 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149835

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	manifest.json	View		1 chunk	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

https://chromiumcodereview.appspot.com/10837040/diff/1/manifest.json File manifest.json (right): https://chromiumcodereview.appspot.com/10837040/diff/1/manifest.json#newcode22 manifest.json:22: "content_security_policy": "default-src 'self'; script-src 'self' https://ssl.google-analytics.com; object-src 'self'; img-src ...

8 years, 4 months ago (2012-08-06 07:00:38 UTC) #2

grovera

8 years, 4 months ago (2012-08-07 13:07:53 UTC) #3

https://chromiumcodereview.appspot.com/10837040/diff/1/manifest.json
File manifest.json (right):

https://chromiumcodereview.appspot.com/10837040/diff/1/manifest.json#newcode22
manifest.json:22: "content_security_policy": "default-src 'self'; script-src
'self' https://ssl.google-analytics.com; object-src 'self'; img-src 'self'
http://www.google-analytics.com; frame-src https://support.google.com;
connect-src https://support.google.com; style-src 'self' 'unsafe-inline'"
On 2012/08/06 07:00:38, abarth wrote:
> Looks fine.  Are you actually using plugins?  If not, please consider setting
> object-src 'none' as that's slightly more secure.

Acknowledged. Since we are not using any plugins, we will set object-src 'none'
in the next manifest commit. Thanks for the inputs.

Expand Messages | Collapse Messages