manifest.json - Issue 10837040: Added support in Helpapp for Manifest Version 2.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: manifest.json

Issue 10837040: Added support in Helpapp for Manifest Version 2. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/browser/resources/help_app/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 {	1 {

2 "key": "MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQCqtHjbcvWT9Kbcapi0SaG28I66eRQHQv OqngCizm87qMb9RTgrftaUAGwPmxFLy4gBwO572N5ACpxsR6m2fRg9PSjeqaEojiFd28KY/b4VPoq/uk NOy97Ns7lPv4gmtNB8txuFIFuNw3s1k8nEJVAp659d7SnMsL4O1uXkW1huGQIDAQAB",	2 "key": "MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQCqtHjbcvWT9Kbcapi0SaG28I66eRQHQv OqngCizm87qMb9RTgrftaUAGwPmxFLy4gBwO572N5ACpxsR6m2fRg9PSjeqaEojiFd28KY/b4VPoq/uk NOy97Ns7lPv4gmtNB8txuFIFuNw3s1k8nEJVAp659d7SnMsL4O1uXkW1huGQIDAQAB",

3 "name": "Help",	3 "name": "Help",

4 "version": "3.1",	4 "version": "3.1",

5 "description": "Chrome OS Help",	5 "description": "Chrome OS Help",

6 "default_locale": "en",	6 "default_locale": "en",

7 "incognito": "split",	7 "incognito": "split",

8 "permissions": [	8 "permissions": [

9 "tabs",	9 "tabs",

10 "https://support.google.com/chromeos//",	10 "https://support.google.com/chromeos//",

11 "chromeosInfoPrivate"	11 "chromeosInfoPrivate"

12 ],	12 ],

13 "content_scripts": [	13 "content_scripts": [

14 {	14 {

15 "matches": ["http://support.google.com/chromeos/", "https://support.googl e.com/chromeos/"],	15 "matches": ["http://support.google.com/chromeos/", "https://support.googl e.com/chromeos/"],

16 "js": ["javascript/contentscript.js"],	16 "js": ["javascript/contentscript.js"],

17 "run_at": "document_end",	17 "run_at": "document_end",

18 "all_frames": true	18 "all_frames": true

19 }	19 }

20 ],	20 ],

21 "content_security_policy": "default-src 'self' https://ssl.google-analytics.co m http://www.google-analytics.com; frame-src https://www.google.com https://supp ort.google.com; connect-src https://www.google.com https://support.google.com; s tyle-src 'self' 'unsafe-inline'"	21 "manifest_version": 2,

	22 "content_security_policy": "default-src 'self'; script-src 'self' https://ssl. google-analytics.com; object-src 'self'; img-src 'self' http://www.google-analyt ics.com; frame-src https://support.google.com; connect-src https://support.googl e.com; style-src 'self' 'unsafe-inline'"
	abarth-chromium 2012/08/06 07:00:38 Looks fine. Are you actually using plugins? If n Looks fine. Are you actually using plugins? If not, please consider setting object-src 'none' as that's slightly more secure. grovera 2012/08/07 13:07:53 Acknowledged. Since we are not using any plugins, Show quoted text On 2012/08/06 07:00:38, abarth wrote: > Looks fine. Are you actually using plugins? If not, please consider setting > object-src 'none' as that's slightly more secure. Acknowledged. Since we are not using any plugins, we will set object-src 'none' in the next manifest commit. Thanks for the inputs.
22 }	23 }

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »