src/x64/lithium-codegen-x64.cc - Issue 10837019: Fix bogus AbortIfNotZeroExtended on x64 for bounds checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 10837019: Fix bogus AbortIfNotZeroExtended on x64 for bounds checks (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index 36de28ff19d93261ed00520d46329e9d004c4585..ad0dc68843ebc9f90703f286acb2e58b846f8f2e 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -3607,7 +3607,7 @@ void LCodeGen::DoBoundsCheck(LBoundsCheck* instr) {

if (instr->length()->IsRegister()) {

if (FLAG_debug_code &&

- !instr->hydrogen()->index()->representation().IsTagged()) {

+ !instr->hydrogen()->length()->representation().IsTagged()) {

__ AbortIfNotZeroExtended(reg);

}

if (instr->index()->IsConstantOperand()) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »