Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 10837019: Fix bogus AbortIfNotZeroExtended on x64 for bounds checks (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3589 matching lines...) Expand 10 before | Expand all | Expand 10 after
3600 break; 3600 break;
3601 } 3601 }
3602 } 3602 }
3603 } 3603 }
3604 3604
3605 3605
3606 void LCodeGen::DoBoundsCheck(LBoundsCheck* instr) { 3606 void LCodeGen::DoBoundsCheck(LBoundsCheck* instr) {
3607 if (instr->length()->IsRegister()) { 3607 if (instr->length()->IsRegister()) {
3608 Register reg = ToRegister(instr->length()); 3608 Register reg = ToRegister(instr->length());
3609 if (FLAG_debug_code && 3609 if (FLAG_debug_code &&
3610 !instr->hydrogen()->index()->representation().IsTagged()) { 3610 !instr->hydrogen()->length()->representation().IsTagged()) {
3611 __ AbortIfNotZeroExtended(reg); 3611 __ AbortIfNotZeroExtended(reg);
3612 } 3612 }
3613 if (instr->index()->IsConstantOperand()) { 3613 if (instr->index()->IsConstantOperand()) {
3614 __ cmpq(reg, 3614 __ cmpq(reg,
3615 Immediate(ToInteger32(LConstantOperand::cast(instr->index())))); 3615 Immediate(ToInteger32(LConstantOperand::cast(instr->index()))));
3616 } else { 3616 } else {
3617 Register reg2 = ToRegister(instr->index()); 3617 Register reg2 = ToRegister(instr->index());
3618 if (FLAG_debug_code && 3618 if (FLAG_debug_code &&
3619 !instr->hydrogen()->index()->representation().IsTagged()) { 3619 !instr->hydrogen()->index()->representation().IsTagged()) {
3620 __ AbortIfNotZeroExtended(reg2); 3620 __ AbortIfNotZeroExtended(reg2);
(...skipping 1450 matching lines...) Expand 10 before | Expand all | Expand 10 after
5071 FixedArray::kHeaderSize - kPointerSize)); 5071 FixedArray::kHeaderSize - kPointerSize));
5072 __ bind(&done); 5072 __ bind(&done);
5073 } 5073 }
5074 5074
5075 5075
5076 #undef __ 5076 #undef __
5077 5077
5078 } } // namespace v8::internal 5078 } } // namespace v8::internal
5079 5079
5080 #endif // V8_TARGET_ARCH_X64 5080 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698