Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 10836307: Merge 125702 - [chromium] Must account for empty transformation lists when checking for big rotatio… (Closed)

8 years, 4 months ago by enne (OOO)
8 years, 4 months ago
Ian Vollick
Base URL:


Merge 125702 - [chromium] Must account for empty transformation lists when checking for big rotations. Reviewed by James Robinson. Source/WebCore: AnimationTranslationUtil.cpp is supposed to reject large rotations (>= 180 degrees between keyframes). The current code assumes that if the lists of transforms at two consecutive keyframes do not match (i.e., are different types), then do not need to reject. The rationale is that we will revert to matrix blending -- we will collapse the lists of transform operations to matrices at each keyframe and blend those. Unfortunately, this is not true if a list is empty. It can be the case that we transition from no transform to a rotation about the z axis of 360 degrees. In this case, the first list of transform operations will be empty and the second will have a single rotation of 360 degrees. An empty list should be treated as a rotation of zero degrees. Unit tested in: GraphicsLayerChromiumTest.createTransformAnimationWithBigRotationAndEmptyTransformOperationList * platform/graphics/chromium/AnimationTranslationUtil.cpp: (WebCore::causesRotationOfAtLeast180Degrees): Source/WebKit/chromium: Adds a test to check that creating an animation with a big (> 180 degree) rotation, where the transform operations list in the 1st keyframe is empty fails as expected. * tests/AnimationTranslationUtilTest.cpp: (WebKit::TEST): (WebKit): Committed:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M Source/WebCore/platform/graphics/chromium/AnimationTranslationUtil.cpp View 1 chunk +21 lines, -9 lines 0 comments Download


Total messages: 1 (0 generated)
enne (OOO)
8 years, 4 months ago (2012-08-17 01:35:45 UTC) #1


Powered by Google App Engine
This is Rietveld 408576698