Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 10836301: Make apps with launch container type panel open as popups. (Closed)

Created:
8 years, 4 months ago by jennb
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Make apps with launch container type panel open as popups. Re-deleted some code that got accidentally added back in. BUG=None TEST=Updated LaunchPanelApp Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152235

Patch Set 1 #

Patch Set 2 : Update LaunchPanelApp test #

Patch Set 3 : Synced #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -49 lines) Patch
M chrome/browser/extensions/api/management/management_apitest.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 6 chunks +0 lines, -44 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jennb
8 years, 4 months ago (2012-08-16 23:27:03 UTC) #1
stevenjb
LGTM, thanks!
8 years, 4 months ago (2012-08-17 00:35:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennb@chromium.org/10836301/1
8 years, 4 months ago (2012-08-17 00:38:19 UTC) #3
commit-bot: I haz the power
Presubmit check for 10836301-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-17 00:38:22 UTC) #4
jennb
Hi Mihai - could I get an extensions OWNER review please? Thanks!
8 years, 4 months ago (2012-08-17 00:55:11 UTC) #5
Mihai Parparita -not on Chrome
LGTM
8 years, 4 months ago (2012-08-17 22:43:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennb@chromium.org/10836301/1004
8 years, 4 months ago (2012-08-18 01:01:30 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-18 03:21:07 UTC) #8
Change committed as 152235

Powered by Google App Engine
This is Rietveld 408576698