Make apps with launch container type panel open as popups.

chrome/browser/extensions/api/management/management_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/extension_test_message_listener.h"
@@ skipping 147 matching lines @@
   ExtensionTestMessageListener launcher_loaded("launcher loaded", false);
   ASSERT_TRUE(LoadExtension(
       test_data_dir_.AppendASCII("management/launch_on_install")));
   ASSERT_TRUE(launcher_loaded.WaitUntilSatisfied());
 
   // Load an app with app.launch.container = "panel".
   std::string app_id;
   LoadAndWaitForLaunch("management/launch_app_panel", &app_id);
   ASSERT_FALSE(HasFatalFailure());  // Stop the test if any ASSERT failed.
 
-  // Find the app's browser.  Check that it is a panel.
+  // Find the app's browser.  Check that it is a popup.
   ASSERT_EQ(2u, browser::GetBrowserCount(browser()->profile()));
   Browser* app_browser = FindOtherBrowser(browser());
-  ASSERT_TRUE(app_browser->is_type_panel());
+  ASSERT_TRUE(app_browser->is_type_popup());
   ASSERT_TRUE(app_browser->is_app());
 
   // Close the app panel.
   content::WindowedNotificationObserver signal(
       chrome::NOTIFICATION_BROWSER_CLOSED,
       content::Source<Browser>(app_browser));
 
   chrome::CloseWindow(app_browser);
   signal.Wait();
 
   // Unload the extension.
   UninstallExtension(app_id);
   ASSERT_EQ(1u, browser::GetBrowserCount(browser()->profile()));
   ASSERT_FALSE(service->GetExtensionById(app_id, true));
 
   // Set a pref indicating that the user wants to launch in a regular tab.
-  // This should be ignored, because panel apps always load in a panel.
+  // This should be ignored, because panel apps always load in a popup.
   service->extension_prefs()->SetLaunchType(
       app_id, extensions::ExtensionPrefs::LAUNCH_REGULAR);
 
   // Load the extension again.
   std::string app_id_new;
   LoadAndWaitForLaunch("management/launch_app_panel", &app_id_new);
   ASSERT_FALSE(HasFatalFailure());
 
   // If the ID changed, then the pref will not apply to the app.
   ASSERT_EQ(app_id, app_id_new);
 
   // Find the app's browser.  Apps that should load in a panel ignore
-  // prefs, so we should still see the launch in a panel.
+  // prefs, so we should still see the launch in a popup.
   ASSERT_EQ(2u, browser::GetBrowserCount(browser()->profile()));
   app_browser = FindOtherBrowser(browser());
-  ASSERT_TRUE(app_browser->is_type_panel());
+  ASSERT_TRUE(app_browser->is_type_popup());
   ASSERT_TRUE(app_browser->is_app());
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, LaunchTabApp) {
   ExtensionService* service = browser()->profile()->GetExtensionService();
 
   // Load an extension that calls launchApp() on any app that gets
   // installed.
   ExtensionTestMessageListener launcher_loaded("launcher loaded", false);
   ASSERT_TRUE(LoadExtension(
@@ skipping 37 matching lines @@
   ASSERT_EQ(2, browser()->tab_count());
 #else
   // Find the app's browser.  Opening in a new window will create
   // a new browser.
   ASSERT_EQ(2u, browser::GetBrowserCount(browser()->profile()));
   Browser* app_browser = FindOtherBrowser(browser());
   ASSERT_TRUE(app_browser->is_app());
   ASSERT_FALSE(app_browser->is_type_panel());
 #endif
 }