Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 10836297: Revert 151169 - [sync] Enable sync credential caching by default for post-M22 builds (Closed)

Created:
8 years, 4 months ago by Raghu Simha
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

Revert 151169 - [sync] Enable sync credential caching by default for post-M22 builds Reason for revert: See bug 143214. CredentialCacheService::GetLastUpdatedTime() is causing a crash in canary builds during upgrade scenarios from older versions. A real fix for the root cause is under review. The earlier revert in https://chromiumcodereview.appspot.com/10830362 is unlikely to fix the root cause. Until then, the safe thing to do is to disable the feature, by reverting r151169. Original CL description: Sync credential caching is a Win 8 feature that allows Metro and Desktop to share sync credentials under some circumstances. The feature is slated to ship with M23, and was disabled for the M22 branch point. Now that M22 has been branched off, it is time to re-enable the feature. This patch turns on the feature by default, and provides users with the "--disable-sync-credential-caching" flag if the feature must be disabled. BUG=139712, 143214 TEST=Sign in on Win 8 and make sure that "Sync Credentials" is written to the default profile directory Old review URL: https://chromiumcodereview.appspot.com/10855063 TBR=tim@chromium.org,zea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/sync/credential_cache_service_factory_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Raghu Simha
8 years, 4 months ago (2012-08-16 21:45:28 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698