Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issue 10855063: [sync] Enable sync credential caching by default for post-M22 builds (Closed)

Created:
8 years, 4 months ago by Raghu Simha
Modified:
8 years, 4 months ago
CC:
chromium-reviews, ncarter (slow), akalin, tim (not reviewing), anantha
Visibility:
Public.

Description

[sync] Enable sync credential caching by default for post-M22 builds Sync credential caching is a Win 8 feature that allows Metro and Desktop to share sync credentials under some circumstances. The feature is slated to ship with M23, and was disabled for the M22 branch point. Now that M22 has been branched off, it is time to re-enable the feature. This patch turns on the feature by default, and provides users with the "--disable-sync-credential-caching" flag if the feature must be disabled. BUG=139712 TEST=Sign in on Win 8 and make sure that "Sync Credentials" is written to the default profile directory Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151169

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/sync/credential_cache_service_factory_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Raghu Simha
Drew, please review. Thanks!
8 years, 4 months ago (2012-08-09 00:05:00 UTC) #1
Raghu Simha
Ping :)
8 years, 4 months ago (2012-08-10 17:58:20 UTC) #2
Andrew T Wilson (Slow)
LGTM, but I think you'll need someone in chrome/OWNERS too for your changes to common/
8 years, 4 months ago (2012-08-10 21:02:44 UTC) #3
Raghu Simha
+Nico for changes to chrome/common.
8 years, 4 months ago (2012-08-10 22:42:46 UTC) #4
Nico
8 years, 4 months ago (2012-08-10 23:16:00 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698